TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-12-23 00:56:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

util/clientmetric: fix regression causing Metric.v to be uninitialised

Browse Source 
m.v was uninitialised when Tailscale built with ts_omit_logtail
Fixes #17918

Signed-off-by: Avery Palmer <quagsirus@catpowered.net>
This commit is contained in:
Avery Palmer
2025-11-15 17:15:14 +00:00
committed by Brad Fitzpatrick
parent 8444659ed8
commit 8aa46a3956
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
util/clientmetric/clientmetric.go
View File

@@ -133,15 +133,18 @@ func (m *Metric) Publish() {
metrics[m.name] = m metrics[m.name] = m
sortedDirty = true sortedDirty = true
if m.f == nil {
if len(valFreeList) == 0 {
valFreeList = make([]int64, 256)
}
m.v = &valFreeList[0]
valFreeList = valFreeList[1:]
}
if buildfeatures.HasLogTail { if buildfeatures.HasLogTail {
if m.f != nil { if m.f != nil {
lastLogVal = append(lastLogVal, scanEntry{f: m.f}) lastLogVal = append(lastLogVal, scanEntry{f: m.f})
} else { } else {
if len(valFreeList) == 0 {
valFreeList = make([]int64, 256)
}
m.v = &valFreeList[0]
valFreeList = valFreeList[1:]
lastLogVal = append(lastLogVal, scanEntry{v: m.v}) lastLogVal = append(lastLogVal, scanEntry{v: m.v})
} }
} }