From 8b5912345edb2a818b19fb5d77d001d2d2bfb190 Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Thu, 27 May 2021 08:10:11 -0700 Subject: [PATCH] cmd/tailscale/cli: don't warn about iptables=off on Synology We don't use iptables on Synology, so don't scare the user. Signed-off-by: Brad Fitzpatrick (cherry picked from commit cdd231cb7d31b95dac8d0385ea6b23acacb00ab1) --- cmd/tailscale/cli/up.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cmd/tailscale/cli/up.go b/cmd/tailscale/cli/up.go index 35b29deb9..88692ecac 100644 --- a/cmd/tailscale/cli/up.go +++ b/cmd/tailscale/cli/up.go @@ -230,7 +230,9 @@ func prefsFromUpArgs(upArgs upArgsT, warnf logger.Logf, st *ipnstate.Status, goo warnf("netfilter=nodivert; add iptables calls to ts-* chains manually.") case "off": prefs.NetfilterMode = preftype.NetfilterOff - warnf("netfilter=off; configure iptables yourself.") + if defaultNetfilterMode() != "off" { + warnf("netfilter=off; configure iptables yourself.") + } default: return nil, fmt.Errorf("invalid value --netfilter-mode=%q", upArgs.netfilterMode) }