TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2024-11-29 04:55:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

wgengine/netstack: disable gVisor GSO on Linux (#13215)

Browse Source 
net/tstun.Wrapper.InjectInboundPacketBuffer is not GSO-aware, which can
break quad-100 TCP streams as a result. Linux is the only platform where
gVisor GSO was previously enabled.

Updates tailscale/corp#22511
Updates #13211

Signed-off-by: Jordan Whited <jordan@tailscale.com>
This commit is contained in:
Jordan Whited 2024-08-21 13:59:29 -07:00 committed by GitHub
parent 4b525fdda0
commit 8e42510a71
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
wgengine/netstack/netstack.go
View File

@ -325,11 +325,11 @@ func Create(logf logger.Logf, tundev *tstun.Wrapper, e wgengine.Engine, mc *magi
if err != nil { if err != nil {
return nil, err return nil, err
} }
var supportedGSOKind stack.SupportedGSO supportedGSOKind := stack.GSONotSupported
var supportedGROKind supportedGRO supportedGROKind := groNotSupported
if runtime.GOOS == "linux" { if runtime.GOOS == "linux" {
// TODO(jwhited): add Windows support https://github.com/tailscale/corp/issues/21874 // TODO(jwhited): add Windows support https://github.com/tailscale/corp/issues/21874
supportedGSOKind = stack.HostGSOSupported // TODO(jwhited): re-enable GSO https://github.com/tailscale/corp/issues/22511
supportedGROKind = tcpGROSupported supportedGROKind = tcpGROSupported
} }
linkEP := newLinkEndpoint(512, uint32(tstun.DefaultTUNMTU()), "", supportedGROKind) linkEP := newLinkEndpoint(512, uint32(tstun.DefaultTUNMTU()), "", supportedGROKind)