all: use testingutil.MinAllocsPerRun

There are a few remaining uses of testing.AllocsPerRun:
Two in which we only log the number of allocations,
and one in which dynamically calculate the allocations
target based on a different AllocsPerRun run.

This also allows us to tighten the "no allocs"
test in wgengine/filter.

Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>
This commit is contained in:
Josh Bleecher Snyder
2021-10-27 16:21:44 -07:00
committed by Josh Bleecher Snyder
parent 1df865a580
commit 94fb42d4b2
11 changed files with 63 additions and 58 deletions

View File

@@ -10,6 +10,7 @@ import (
"testing"
"inet.af/netaddr"
"tailscale.com/tstest"
"tailscale.com/types/ipproto"
)
@@ -378,11 +379,11 @@ func TestParsedString(t *testing.T) {
})
}
allocs := testing.AllocsPerRun(1000, func() {
err := tstest.MinAllocsPerRun(t, 1, func() {
sinkString = tests[0].qdecode.String()
})
if allocs != 1 {
t.Errorf("allocs = %v; want 1", allocs)
if err != nil {
t.Error(err)
}
}
@@ -415,12 +416,12 @@ func TestDecode(t *testing.T) {
})
}
allocs := testing.AllocsPerRun(1000, func() {
err := tstest.MinAllocsPerRun(t, 0, func() {
var got Parsed
got.Decode(tests[0].buf)
})
if allocs != 0 {
t.Errorf("allocs = %v; want 0", allocs)
if err != nil {
t.Error(err)
}
}