TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-10-09 08:01:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

net/netmon: always remember ifState as old state, even on minor changes

Browse Source 
Otherwise you can get stuck finding minor ones nonstop.

Fixes #15484

Change-Id: I7f98ac338c0b32ec1b9fdc47d053207b5fc1bf23
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
This commit is contained in:
Brad Fitzpatrick
2025-03-30 21:11:41 -07:00
committed by Brad Fitzpatrick
parent e720b9824e
commit 96fe8a6db6
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
net/netmon/netmon.go
View File

@@ -441,7 +441,6 @@ func (m *Monitor) handlePotentialChange(newState *State, forceCallbacks bool) {
delta.Major = m.IsMajorChangeFrom(oldState, newState) delta.Major = m.IsMajorChangeFrom(oldState, newState)
if delta.Major { if delta.Major {
m.gwValid = false m.gwValid = false
m.ifState = newState
if s1, s2 := oldState.String(), delta.New.String(); s1 == s2 { if s1, s2 := oldState.String(), delta.New.String(); s1 == s2 {
m.logf("[unexpected] network state changed, but stringification didn't: %v", s1) m.logf("[unexpected] network state changed, but stringification didn't: %v", s1)
@@ -449,6 +448,7 @@ func (m *Monitor) handlePotentialChange(newState *State, forceCallbacks bool) {
m.logf("[unexpected] new: %s", jsonSummary(newState)) m.logf("[unexpected] new: %s", jsonSummary(newState))
} }
} }
m.ifState = newState
// See if we have a queued or new time jump signal. // See if we have a queued or new time jump signal.
if timeJumped { if timeJumped {
m.resetTimeJumpedLocked() m.resetTimeJumpedLocked()