TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2024-11-29 13:05:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmd/k8s-operator: sanitize connection headers (#10063)

Browse Source 
Fixes tailscale/corp#15526

Signed-off-by: Rhea Ghosh <rhea@tailscale.com>
This commit is contained in:
Rhea Ghosh 2023-11-01 13:15:57 -05:00 committed by GitHub
parent ca4c940a4d
commit 970eb5e784
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
cmd/k8s-operator/proxy.go
View File

@ -166,10 +166,11 @@ func runAPIServerProxy(s *tsnet.Server, rt http.RoundTripper, logf logger.Logf,
logf: logf, logf: logf,
lc: lc, lc: lc,
rp: &httputil.ReverseProxy{ rp: &httputil.ReverseProxy{
Director: func(r *http.Request) { Rewrite: func(r *httputil.ProxyRequest) {
// Replace the URL with the Kubernetes APIServer. // Replace the URL with the Kubernetes APIServer.
r.URL.Scheme = u.Scheme
r.URL.Host = u.Host r.Out.URL.Scheme = u.Scheme
r.Out.URL.Host = u.Host
if mode == apiserverProxyModeNoAuth { if mode == apiserverProxyModeNoAuth {
// If we are not providing authentication, then we are just // If we are not providing authentication, then we are just
// proxying to the Kubernetes API, so we don't need to do // proxying to the Kubernetes API, so we don't need to do
@ -184,18 +185,18 @@ func runAPIServerProxy(s *tsnet.Server, rt http.RoundTripper, logf logger.Logf,
// Out of paranoia, remove all authentication headers that might // Out of paranoia, remove all authentication headers that might
// have been set by the client. // have been set by the client.
r.Header.Del("Authorization") r.Out.Header.Del("Authorization")
r.Header.Del("Impersonate-Group") r.Out.Header.Del("Impersonate-Group")
r.Header.Del("Impersonate-User") r.Out.Header.Del("Impersonate-User")
r.Header.Del("Impersonate-Uid") r.Out.Header.Del("Impersonate-Uid")
for k := range r.Header { for k := range r.Out.Header {
if strings.HasPrefix(k, "Impersonate-Extra-") { if strings.HasPrefix(k, "Impersonate-Extra-") {
r.Header.Del(k) r.Out.Header.Del(k)
} }
} }
// Now add the impersonation headers that we want. // Now add the impersonation headers that we want.
if err := addImpersonationHeaders(r); err != nil { if err := addImpersonationHeaders(r.Out); err != nil {
panic("failed to add impersonation headers: " + err.Error()) panic("failed to add impersonation headers: " + err.Error())
} }
}, },