TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-04-18 20:51:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

syncs: re-enable TestWatchMultipleValues

Browse Source 
We've updated to a different set of CI machines since this test
was disabled.

Fixes https://github.com/tailscale/tailscale/issues/1513

Signed-off-by: Denton Gentry <dgentry@tailscale.com>
This commit is contained in:
Denton Gentry 2022-08-27 11:16:43 -07:00 committed by Denton Gentry
parent 0582829e00
commit 9ab992e7a1
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
syncs/watchdog_test.go
View File

@ -8,8 +8,6 @@ import (
"sync" "sync"
"testing" "testing"
"time" "time"
"tailscale.com/util/cibuild"
) )
// Time-based tests are fundamentally flaky. // Time-based tests are fundamentally flaky.
@ -47,12 +45,6 @@ func TestWatchContended(t *testing.T) {
} }
func TestWatchMultipleValues(t *testing.T) { func TestWatchMultipleValues(t *testing.T) {
if cibuild.On() {
// On the CI machine, it sometimes takes 500ms to start a new goroutine.
// When this happens, we don't get enough events quickly enough.
// Nothing's wrong, and it's not worth working around. Just skip the test.
t.Skip("flaky on CI")
}
mu := new(sync.Mutex) mu := new(sync.Mutex)
ctx, cancel := context.WithCancel(context.Background()) ctx, cancel := context.WithCancel(context.Background())
defer cancel() // not necessary, but keep vet happy defer cancel() // not necessary, but keep vet happy