From 9eaa56df93261aa56e555c1a5b5fb13c44d395a6 Mon Sep 17 00:00:00 2001 From: James Tucker Date: Tue, 2 Apr 2024 15:42:41 -0700 Subject: [PATCH] tsweb: update doc on BucketedStatsOptions.Finish to match behavior I originally came to update this to match the documented behavior, but the code is deliberately avoiding this behavior currently, making it hard to decide how to update this. For now just align the documentation to the behavior. Updates #cleanup Signed-off-by: James Tucker --- tsweb/tsweb.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tsweb/tsweb.go b/tsweb/tsweb.go index 7361f8742..8841c8c5d 100644 --- a/tsweb/tsweb.go +++ b/tsweb/tsweb.go @@ -189,7 +189,8 @@ type BucketedStatsOptions struct { Started *metrics.LabelMap // If non-nil, Finished maintains a counter of all requests which - // have finished processing (that is, the HTTP handler has returned). + // have finished processing with success (that is, the HTTP handler has + // returned). Finished *metrics.LabelMap }