TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-10-15 10:49:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

wgengine/magicsock: fix data race regression in disco ping callbacks

Browse Source 
Regression from c15997511d. The callback could be run multiple times
from different endpoints.

Fixes #9801

Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
This commit is contained in:
Brad Fitzpatrick
2023-10-14 13:16:04 -07:00
committed by Brad Fitzpatrick
parent 5297bd2cff
commit a6270826a3
2 changed files with 33 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
wgengine/magicsock/magicsock.go
View File

@@ -757,7 +757,7 @@ func (c *Conn) Ping(peer tailcfg.NodeView, res *ipnstate.PingResult, size int, c
cb(res)
return
}
ep.cliPing(res, size, cb)
ep.discoPing(res, size, cb)
}
// c.mu must be held