TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-07-30 07:43:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

tailcfg: remove outdated comments about Clone methods

Browse Source 
The cloner tool adds static checks that the Clone methods are up to
date, so failing to update Clone causes a compiler error.

Signed-off-by: David Crawshaw <crawshaw@tailscale.com>
This commit is contained in:
David Crawshaw 2020-11-23 09:28:32 -05:00
parent aa9d7f4665
commit a6b60d61d7
1 changed files with 2 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tailcfg/tailcfg.go
View File

@ -112,8 +112,6 @@ type User struct {
Logins []LoginID Logins []LoginID
Roles []RoleID Roles []RoleID
Created time.Time Created time.Time
// Note: be sure to update Clone when adding new fields
} }
type Login struct { type Login struct {
@ -156,9 +154,6 @@ type Node struct {
KeepAlive bool // open and keep open a connection to this peer KeepAlive bool // open and keep open a connection to this peer
MachineAuthorized bool // TODO(crawshaw): replace with MachineStatus MachineAuthorized bool // TODO(crawshaw): replace with MachineStatus
// NOTE: any new fields containing pointers in this type
// require changes to Node.Clone.
} }
type MachineStatus int type MachineStatus int
@ -275,9 +270,6 @@ type Service struct {
Description string `json:",omitempty"` // text description of service Description string `json:",omitempty"` // text description of service
// TODO(apenwarr): allow advertising services on subnet IPs? // TODO(apenwarr): allow advertising services on subnet IPs?
// TODO(apenwarr): add "tags" here for each service? // TODO(apenwarr): add "tags" here for each service?
// NOTE: any new fields containing pointers in this type
// require changes to Hostinfo.Clone.
} }
// Hostinfo contains a summary of a Tailscale host. // Hostinfo contains a summary of a Tailscale host.
@ -301,7 +293,7 @@ type Hostinfo struct {
NetInfo *NetInfo `json:",omitempty"` NetInfo *NetInfo `json:",omitempty"`
// NOTE: any new fields containing pointers in this type // NOTE: any new fields containing pointers in this type
// require changes to Hostinfo.Clone and Hostinfo.Equal. // require changes to Hostinfo.Equal.
} }
// NetInfo contains information about the host's network state. // NetInfo contains information about the host's network state.
@ -353,7 +345,7 @@ type NetInfo struct {
// the control plane. // the control plane.
DERPLatency map[string]float64 `json:",omitempty"` DERPLatency map[string]float64 `json:",omitempty"`
// Update Clone and BasicallyEqual when adding fields. // Update BasicallyEqual when adding fields.
} }
func (ni *NetInfo) String() string { func (ni *NetInfo) String() string {