TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2024-12-04 15:35:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

WIP: tolerate ip6tables failures.

Browse Source 
It comes up reasonably often that a host has IPv6 configured
but broken or non-functional in some way. One recent example is
https://github.com/gitpod-io/gitpod/issues/8049 where the sypmtoms
were:
1. an error message and health check failure about ip6tables
2. MagicDNS didn't work, even for IPv4

MagicDNS is broken because the failure to initialize IPv6 returns
an error which stops the rest of the initialization. I think we
have another case where IPv6 failing results in not acceping IPv4
subnet routes. Clearly we'd prefer not to have subsets of
functionality be mysteriously broken.

This PR is not the right way to do it, but serves as a proof of concept
that tolerating IPv6 failures results in fixing https://github.com/gitpod-io/gitpod/issues/8049
without needing the workaround which gitpod put together.

Fixes https://github.com/tailscale/tailscale/issues/3002

Signed-off-by: Denton Gentry <dgentry@tailscale.com>
This commit is contained in:
Denton Gentry 2022-07-04 09:05:01 -07:00
parent e8f09d24c7
commit a78b8c14a4
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
wgengine/router/router_linux.go
View File

@ -1081,8 +1081,15 @@ func (r *linuxRouter) addNetfilterChains() error {
for _, ipt := range r.netfilterFamilies() {
if err := create(ipt, "filter", "ts-input"); err != nil {
if ipt == r.ipt6 {
r.v6Available = false
r.v6NATAvailable = false
r.logf("addNetfilterChains ipt6 failed, disabling IPv6 and continuing. Error was: %v", err)
continue
} else {
return err
}
}
if err := create(ipt, "filter", "ts-forward"); err != nil {
return err
}
@ -1106,7 +1113,8 @@ func (r *linuxRouter) addNetfilterBase() error {
}
if r.v6Available {
if err := r.addNetfilterBase6(); err != nil {
return err
r.v6Available = false
r.logf("addNetfilterBase6 failed, disabling IPv6 and continuing. Error was: %v", err)
}
}
return nil