TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-12-24 01:26:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

net/*: remove Windows exceptions for when Resolver.PreferGo didn't work

Browse Source 
Resolver.PreferGo didn't used to work on Windows.

It was fixed in 2022, though. (https://github.com/golang/go/issues/33097)

Updates #5161

Change-Id: I4e1aeff220ebd6adc8a14f781664fa6a2068b48c
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
This commit is contained in:
Brad Fitzpatrick
2025-06-17 20:25:09 -07:00
committed by Brad Fitzpatrick
parent fcab50b276
commit ad0dfcb185
3 changed files with 1 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
net/dnscache/messagecache_test.go
View File

@@ -9,7 +9,6 @@ import (
"errors"
"fmt"
"net"
"runtime"
"testing"
"time"
@@ -249,14 +248,6 @@ func TestGetDNSQueryCacheKey(t *testing.T) {
}
func getGoNetPacketDNSQuery(name string) []byte {
if runtime.GOOS == "windows" {
// On Windows, Go's net.Resolver doesn't use the DNS client.
// See https://github.com/golang/go/issues/33097 which
// was approved but not yet implemented.
// For now just pretend it's implemented to make this test
// pass on Windows with complicated the caller.
return makeQ(123, name)
}
res := make(chan []byte, 1)
r := &net.Resolver{
PreferGo: true,