TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2024-12-04 15:35:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

net/portmapper: make pcpCodeNotAuthorized log more descriptive

Browse Source 
If PCP is present but disabled, turning it on might help
get direct connections.

Signed-off-by: Denton Gentry <dgentry@tailscale.com>
(cherry picked from commit de4c635e54)
This commit is contained in:
Denton Gentry 2022-06-10 22:13:24 -07:00 committed by Denton Gentry
parent e7d5d90037
commit b39592f68a
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
net/portmapper/pcp.go
View File

@ -115,6 +115,9 @@ func parsePCPMapResponse(resp []byte) (*pcpMapping, error) {
if !ok { if !ok {
return nil, fmt.Errorf("Invalid PCP common header") return nil, fmt.Errorf("Invalid PCP common header")
} }
if res.ResultCode == pcpCodeNotAuthorized {
return nil, fmt.Errorf("PCP is implemented but not enabled in the router")
}
if res.ResultCode != pcpCodeOK { if res.ResultCode != pcpCodeOK {
return nil, fmt.Errorf("PCP response not ok, code %d", res.ResultCode) return nil, fmt.Errorf("PCP response not ok, code %d", res.ResultCode)
} }