TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-04-06 00:05:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

ipn/localapi: also allow localhost as the LocalAPI host

Browse Source 
The Mac and iOS LocalAPI clients make requests to it.

Signed-off-by: Mihai Parparita <mihai@tailscale.com>
This commit is contained in:
Mihai Parparita 2022-11-16 11:35:01 -08:00 committed by Mihai Parparita
parent b0736fe6f7
commit b3da5de10f
1 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
ipn/localapi/localapi.go
View File

@ -168,15 +168,26 @@ func validHost(h string) bool {
case "", apitype.LocalAPIHost: case "", apitype.LocalAPIHost:
return true return true
} }
// Otherwise, any Host header we see should at most be an ip:port. // Allow either localhost or loopback IP hosts.
ap, err := netip.ParseAddrPort(h) host, portStr, err := net.SplitHostPort(h)
if err != nil { if err != nil {
return false return false
} }
if runtime.GOOS == "windows" && ap.Port() != safesocket.WindowsLocalPort { port, err := strconv.ParseUint(portStr, 10, 16)
if err != nil {
return false return false
} }
return ap.Addr().IsLoopback() if runtime.GOOS == "windows" && port != safesocket.WindowsLocalPort {
return false
}
if host == "localhost" {
return true
}
addr, err := netip.ParseAddr(h)
if err != nil {
return false
}
return addr.IsLoopback()
} }
// handlerForPath returns the LocalAPI handler for the provided Request.URI.Path. // handlerForPath returns the LocalAPI handler for the provided Request.URI.Path.