TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-04-09 09:44:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

logtail: start a local server for TestFastShutdown

Browse Source 
Right now TestFastShutdown tries to upload logs to localhost:1234,
which will most likely respond with an error. However if one has an
actual service running on port 1234, it would receive a connection
attempting to POST every time the unit test runs.

Start a local server and direct the upload there instead.

Signed-off-by: Denton Gentry <dgentry@tailscale.com>
This commit is contained in:
Denton Gentry 2021-01-11 06:22:35 -08:00 committed by Denton Gentry
parent 2e9728023b
commit b771a1363b
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
logtail/logtail_test.go
View File

@ -16,8 +16,12 @@ func TestFastShutdown(t *testing.T) {
ctx, cancel := context.WithCancel(context.Background()) ctx, cancel := context.WithCancel(context.Background())
cancel() cancel()
testServ := httptest.NewServer(http.HandlerFunc(
func(w http.ResponseWriter, r *http.Request) {}))
defer testServ.Close()
l := NewLogger(Config{ l := NewLogger(Config{
BaseURL: "http://localhost:1234", BaseURL: testServ.URL,
}, t.Logf) }, t.Logf)
l.Shutdown(ctx) l.Shutdown(ctx)
} }
@ -30,6 +34,7 @@ func TestUploadMessages(t *testing.T) {
w.Header().Set("Content-Type", "application/json; charset=utf-8") w.Header().Set("Content-Type", "application/json; charset=utf-8")
uploads += 1 uploads += 1
})) }))
defer testServ.Close()
l := NewLogger(Config{BaseURL: testServ.URL}, t.Logf) l := NewLogger(Config{BaseURL: testServ.URL}, t.Logf)
for i := 1; i < 10; i++ { for i := 1; i < 10; i++ {