From b8ad90c2bf89de3637375cb82085fa282ba70cb0 Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Tue, 11 Jan 2022 08:11:18 -0800 Subject: [PATCH] cmd/derper: in manual cert mode, don't discard error from VerifyHostname Updates #3701 Change-Id: If8ca5104bd8221c99cc390ca49ee3401aff09b62 Signed-off-by: Brad Fitzpatrick --- cmd/derper/cert.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/derper/cert.go b/cmd/derper/cert.go index dd71c3af2..972540397 100644 --- a/cmd/derper/cert.go +++ b/cmd/derper/cert.go @@ -67,8 +67,8 @@ func NewManualCertManager(certdir, hostname string) (certProvider, error) { if err != nil { return nil, fmt.Errorf("can not load cert: %w", err) } - if x509Cert.VerifyHostname(hostname) != nil { - return nil, errors.New("refuse to load cert: hostname mismatch with key") + if err := x509Cert.VerifyHostname(hostname); err != nil { + return nil, fmt.Errorf("cert invalid for hostname %q: %w", hostname, err) } return &manualCertManager{cert: &cert, hostname: hostname}, nil }