TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-04-22 08:51:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmd/cli: remove --webclient flag from up

Browse Source 
Causing issues building a stable release. Getting rid of the flag
for now because it was only available in unstable, can still be
turned on through localapi.

A #cleanup

Co-authored-by: Will Norris <will@tailscale.com>
Signed-off-by: Sonia Appasamy <sonia@tailscale.com>
This commit is contained in:
Sonia Appasamy 2023-11-15 12:31:21 -05:00 committed by Sonia Appasamy
parent 1cb8d2ffdd
commit bb31912ea5
2 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
cmd/tailscale/cli/cli_test.go
View File

@ -905,7 +905,6 @@ func TestUpdatePrefs(t *testing.T) {
OperatorUserSet: true, OperatorUserSet: true,
RouteAllSet: true, RouteAllSet: true,
RunSSHSet: true, RunSSHSet: true,
RunWebClientSet: true,
ShieldsUpSet: true, ShieldsUpSet: true,
WantRunningSet: true, WantRunningSet: true,
}, },

5
cmd/tailscale/cli/up.go
View File

@ -116,11 +116,6 @@ func newUpFlagSet(goos string, upArgs *upArgsT, cmd string) *flag.FlagSet {
upf.BoolVar(&upArgs.advertiseConnector, "advertise-connector", false, "advertise this node as an app connector") upf.BoolVar(&upArgs.advertiseConnector, "advertise-connector", false, "advertise this node as an app connector")
upf.BoolVar(&upArgs.advertiseDefaultRoute, "advertise-exit-node", false, "offer to be an exit node for internet traffic for the tailnet") upf.BoolVar(&upArgs.advertiseDefaultRoute, "advertise-exit-node", false, "offer to be an exit node for internet traffic for the tailnet")
// TODO(tailscale/corp#14335): during development only expose -webclient on dev and unstable builds
if version.GetMeta().IsDev || version.IsUnstableBuild() {
upf.BoolVar(&upArgs.runWebClient, "webclient", false, "run a web client, permitting access per tailnet admin's declared policy")
}
if safesocket.GOOSUsesPeerCreds(goos) { if safesocket.GOOSUsesPeerCreds(goos) {
upf.StringVar(&upArgs.opUser, "operator", "", "Unix username to allow to operate on tailscaled without sudo") upf.StringVar(&upArgs.opUser, "operator", "", "Unix username to allow to operate on tailscaled without sudo")
} }