TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-02-22 12:58:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmd/tailscale/cli: disallow empty text "" from serve CLI (#6416)

Browse Source 
Current behavior is broken. tailscale serve text / "" returns no error
and shows up in tailscale serve status but requests return a 500
"empty handler".

Adds an error if the user passes in an empty string for the text
handler.

Closes #6405

Signed-off-by: Shayne Sweeney <shayne@tailscale.com>
This commit is contained in:
shayne 2022-11-20 15:04:58 -05:00 committed by GitHub
parent d1e1c025b0
commit bdd8ce6692
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
cmd/tailscale/cli/serve.go
View File

@ -285,6 +285,9 @@ func (e *serveEnv) runServe(ctx context.Context, args []string) error {
} }
h.Proxy = t h.Proxy = t
case "text": case "text":
if args[2] == "" {
return errors.New("unable to serve; text cannot be an empty string")
}
h.Text = args[2] h.Text = args[2]
default: default:
fmt.Fprintf(os.Stderr, "error: unknown serve type %q\n\n", args[1]) fmt.Fprintf(os.Stderr, "error: unknown serve type %q\n\n", args[1])