TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-02-16 18:08:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

wgengine/router: make v6-ness configurable in test, for consistent results.

Browse Source 
Signed-off-by: David Anderson <danderson@tailscale.com>
This commit is contained in:
David Anderson 2020-09-28 23:46:39 +00:00
parent d3701417fc
commit c493e5804f
2 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
wgengine/router/router_linux.go
View File

@ -113,8 +113,11 @@ func newUserspaceRouter(logf logger.Logf, _ *device.Device, tunDev tun.Device) (
return nil, err return nil, err
} }
supportsV6 := supportsV6()
supportsV6NAT := supportsV6 && supportsV6NAT()
var ipt6 netfilterRunner var ipt6 netfilterRunner
if supportsV6() { if supportsV6 {
// The iptables package probes for `ip6tables` and errors out // The iptables package probes for `ip6tables` and errors out
// if unavailable. We want that to be a non-fatal error. // if unavailable. We want that to be a non-fatal error.
ipt6, err = iptables.NewWithProtocol(iptables.ProtocolIPv6) ipt6, err = iptables.NewWithProtocol(iptables.ProtocolIPv6)
@ -123,10 +126,10 @@ func newUserspaceRouter(logf logger.Logf, _ *device.Device, tunDev tun.Device) (
} }
} }
return newUserspaceRouterAdvanced(logf, tunname, ipt4, ipt6, osCommandRunner{}) return newUserspaceRouterAdvanced(logf, tunname, ipt4, ipt6, osCommandRunner{}, supportsV6, supportsV6NAT)
} }
func newUserspaceRouterAdvanced(logf logger.Logf, tunname string, netfilter4, netfilter6 netfilterRunner, cmd commandRunner) (Router, error) { func newUserspaceRouterAdvanced(logf logger.Logf, tunname string, netfilter4, netfilter6 netfilterRunner, cmd commandRunner, supportsV6, supportsV6NAT bool) (Router, error) {
ipRuleAvailable := (cmd.run("ip", "rule") == nil) ipRuleAvailable := (cmd.run("ip", "rule") == nil)
mconfig := dns.ManagerConfig{ mconfig := dns.ManagerConfig{
@ -134,8 +137,6 @@ func newUserspaceRouterAdvanced(logf logger.Logf, tunname string, netfilter4, ne
InterfaceName: tunname, InterfaceName: tunname,
} }
supportsV6 := supportsV6()
return &linuxRouter{ return &linuxRouter{
logf: logf, logf: logf,
tunname: tunname, tunname: tunname,
@ -143,7 +144,7 @@ func newUserspaceRouterAdvanced(logf logger.Logf, tunname string, netfilter4, ne
ipRuleAvailable: ipRuleAvailable, ipRuleAvailable: ipRuleAvailable,
v6Available: supportsV6, v6Available: supportsV6,
v6NATAvailable: supportsV6 && supportsV6NAT(), v6NATAvailable: supportsV6NAT,
ipt4: netfilter4, ipt4: netfilter4,
ipt6: netfilter6, ipt6: netfilter6,
@ -1003,10 +1004,8 @@ func supportsV6() bool {
// Some distros ship ip6tables separately from iptables. // Some distros ship ip6tables separately from iptables.
if _, err := exec.LookPath("ip6tables"); err != nil { if _, err := exec.LookPath("ip6tables"); err != nil {
if _, err := os.Stat("/sbin/ip6tables"); err != nil {
return false return false
} }
}
return true return true
} }

2
wgengine/router/router_linux_test.go
View File

@ -279,7 +279,7 @@ v6/nat/POSTROUTING -j ts-postrouting
} }
fake := NewFakeOS(t) fake := NewFakeOS(t)
router, err := newUserspaceRouterAdvanced(t.Logf, "tailscale0", fake.netfilter4, fake.netfilter6, fake) router, err := newUserspaceRouterAdvanced(t.Logf, "tailscale0", fake.netfilter4, fake.netfilter6, fake, true, true)
if err != nil { if err != nil {
t.Fatalf("failed to create router: %v", err) t.Fatalf("failed to create router: %v", err)
} }