TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-04-06 00:05:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

derp: tcp-write-timeout=0 should disable write deadline (#14895)

Browse Source 
Updates tailscale/corp#26316

Signed-off-by: Jordan Whited <jordan@tailscale.com>
This commit is contained in:
Jordan Whited 2025-02-03 15:14:16 -08:00 committed by GitHub
parent 80a100b3cb
commit cfe578870d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
derp/derp_server.go
View File

@ -1827,6 +1827,14 @@ func (c *sclient) setWriteDeadline() {
// of connected peers. // of connected peers.
d = privilegedWriteTimeout d = privilegedWriteTimeout
} }
if d == 0 {
// A zero value should disable the write deadline per
// --tcp-write-timeout docs. The flag should only be applicable for
// non-mesh connections, again per its docs. If mesh happened to use a
// zero value constant above it would be a bug, so we don't bother
// with a condition on c.canMesh.
return
}
// Ignore the error from setting the write deadline. In practice, // Ignore the error from setting the write deadline. In practice,
// setting the deadline will only fail if the connection is closed // setting the deadline will only fail if the connection is closed
// or closing, so the subsequent Write() will fail anyway. // or closing, so the subsequent Write() will fail anyway.