TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-04-02 22:35:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

clientupdate: cache CanAutoUpdate, avoid log spam when false

Browse Source 
I noticed logs on one of my machines where it can't auto-update with
scary log spam about "failed to apply tailnet-wide default for
auto-updates".

This avoids trying to do the EditPrefs if we know it's just going to
fail anyway.

Updates #282

Change-Id: Ib7db3b122185faa70efe08b60ebd05a6094eed8c
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
This commit is contained in:
Brad Fitzpatrick 2025-03-23 15:39:54 -07:00 committed by Brad Fitzpatrick
parent 6bbf98bef4
commit d0c50c6072
2 changed files with 20 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
clientupdate/clientupdate.go
View File

@ -28,6 +28,7 @@ import (
"strings" "strings"
"tailscale.com/hostinfo" "tailscale.com/hostinfo"
"tailscale.com/types/lazy"
"tailscale.com/types/logger" "tailscale.com/types/logger"
"tailscale.com/util/cmpver" "tailscale.com/util/cmpver"
"tailscale.com/version" "tailscale.com/version"
@ -249,9 +250,13 @@ func (up *Updater) getUpdateFunction() (fn updateFunction, canAutoUpdate bool) {
return nil, false return nil, false
} }
var canAutoUpdateCache lazy.SyncValue[bool]
// CanAutoUpdate reports whether auto-updating via the clientupdate package // CanAutoUpdate reports whether auto-updating via the clientupdate package
// is supported for the current os/distro. // is supported for the current os/distro.
func CanAutoUpdate() bool { func CanAutoUpdate() bool { return canAutoUpdateCache.Get(canAutoUpdateUncached) }
func canAutoUpdateUncached() bool {
if version.IsMacSysExt() { if version.IsMacSysExt() {
// Macsys uses Sparkle for auto-updates, which doesn't have an update // Macsys uses Sparkle for auto-updates, which doesn't have an update
// function in this package. // function in this package.

26
ipn/ipnlocal/local.go
View File

@ -3479,18 +3479,20 @@ func (b *LocalBackend) onTailnetDefaultAutoUpdate(au bool) {
// can still manually enable auto-updates on this node. // can still manually enable auto-updates on this node.
return return
} }
b.logf("using tailnet default auto-update setting: %v", au) if clientupdate.CanAutoUpdate() {
prefsClone := prefs.AsStruct() b.logf("using tailnet default auto-update setting: %v", au)
prefsClone.AutoUpdate.Apply = opt.NewBool(au) prefsClone := prefs.AsStruct()
_, err := b.editPrefsLockedOnEntry(&ipn.MaskedPrefs{ prefsClone.AutoUpdate.Apply = opt.NewBool(au)
Prefs: *prefsClone, _, err := b.editPrefsLockedOnEntry(&ipn.MaskedPrefs{
AutoUpdateSet: ipn.AutoUpdatePrefsMask{ Prefs: *prefsClone,
ApplySet: true, AutoUpdateSet: ipn.AutoUpdatePrefsMask{
}, ApplySet: true,
}, unlock) },
if err != nil { }, unlock)
b.logf("failed to apply tailnet-wide default for auto-updates (%v): %v", au, err) if err != nil {
return b.logf("failed to apply tailnet-wide default for auto-updates (%v): %v", au, err)
return
}
} }
} }