TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-12-05 04:11:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

util/deephash: move map logic to separate function (#5464)

Browse Source 
This helps pprof better identify which Go kinds take the most time
since the kind is always in the function name.

There is a minor adjustment where we hash the length of the map
to be more on the cautious side.

Signed-off-by: Joe Tsai <joetsai@digital-static.net>
This commit is contained in:
Joe Tsai
2022-08-27 15:49:26 -07:00
committed by GitHub
parent 23c3831ff9
commit d2e2d8438b
2 changed files with 64 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
util/deephash/deephash_test.go
View File

@@ -747,14 +747,13 @@ func TestHashMapAcyclic(t *testing.T) {
hb := &hashBuffer{Hash: sha256.New()}
ti := getTypeInfo(reflect.TypeOf(m))
hash := getTypeInfo(reflect.TypeOf(m)).hasher()
for i := 0; i < 20; i++ {
v := reflect.ValueOf(&m).Elem()
va := reflect.ValueOf(&m).Elem()
hb.Reset()
h := new(hasher)
h.Block512.Hash = hb
h.hashMap(v, ti)
hash(h, pointerOf(va.Addr()))
h.sum()
if got[string(hb.B)] {
continue
@@ -793,14 +792,14 @@ func BenchmarkHashMapAcyclic(b *testing.B) {
hb := &hashBuffer{Hash: sha256.New()}
va := reflect.ValueOf(&m).Elem()
ti := getTypeInfo(va.Type())
hash := getTypeInfo(va.Type()).hasher()
h := new(hasher)
h.Block512.Hash = hb
for i := 0; i < b.N; i++ {
h.Reset()
h.hashMap(va, ti)
hash(h, pointerOf(va.Addr()))
}
}