TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-12-23 09:06:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmd/k8s-operator: don't log errors on not found objects. (#18142)

Browse Source 
The event queue gets deleted events, which means that sometimes
the object that should be reconciled no longer exists.
Don't log user facing errors if that is the case.

Updates #18141

Signed-off-by: Irbe Krumina <irbe@tailscale.com>
This commit is contained in:
Irbe Krumina
2025-12-08 11:19:01 +00:00
committed by GitHub
parent d349370e55
commit d5c893195b
1 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
cmd/k8s-operator/operator.go
View File

@@ -27,6 +27,7 @@ import (
rbacv1 "k8s.io/api/rbac/v1" rbacv1 "k8s.io/api/rbac/v1"
apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1" apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
apiequality "k8s.io/apimachinery/pkg/api/equality" apiequality "k8s.io/apimachinery/pkg/api/equality"
apierrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/fields" "k8s.io/apimachinery/pkg/fields"
klabels "k8s.io/apimachinery/pkg/labels" klabels "k8s.io/apimachinery/pkg/labels"
@@ -1018,7 +1019,9 @@ func nodeHandlerForProxyGroup(cl client.Client, defaultProxyClass string, logger
proxyClass := &tsapi.ProxyClass{} proxyClass := &tsapi.ProxyClass{}
if err := cl.Get(ctx, types.NamespacedName{Name: pc}, proxyClass); err != nil { if err := cl.Get(ctx, types.NamespacedName{Name: pc}, proxyClass); err != nil {
logger.Debugf("error getting ProxyClass %q: %v", pg.Spec.ProxyClass, err) if !apierrors.IsNotFound(err) {
logger.Debugf("error getting ProxyClass %q: %v", pg.Spec.ProxyClass, err)
}
return nil return nil
} }
@@ -1275,7 +1278,9 @@ func ingressSvcFromEps(cl client.Client, logger *zap.SugaredLogger) handler.MapF
svc := &corev1.Service{} svc := &corev1.Service{}
ns := o.GetNamespace() ns := o.GetNamespace()
if err := cl.Get(ctx, types.NamespacedName{Name: svcName, Namespace: ns}, svc); err != nil { if err := cl.Get(ctx, types.NamespacedName{Name: svcName, Namespace: ns}, svc); err != nil {
logger.Errorf("failed to get service: %v", err) if !apierrors.IsNotFound(err) {
logger.Debugf("failed to get service: %v", err)
}
return nil return nil
} }
@@ -1450,7 +1455,9 @@ func kubeAPIServerPGsFromSecret(cl client.Client, logger *zap.SugaredLogger) han
var pg tsapi.ProxyGroup var pg tsapi.ProxyGroup
if err := cl.Get(ctx, types.NamespacedName{Name: secret.ObjectMeta.Labels[LabelParentName]}, &pg); err != nil { if err := cl.Get(ctx, types.NamespacedName{Name: secret.ObjectMeta.Labels[LabelParentName]}, &pg); err != nil {
logger.Infof("error getting ProxyGroup %s: %v", secret.ObjectMeta.Labels[LabelParentName], err) if !apierrors.IsNotFound(err) {
logger.Debugf("error getting ProxyGroup %s: %v", secret.ObjectMeta.Labels[LabelParentName], err)
}
return nil return nil
} }