TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2024-11-29 13:05:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

net/dns/resolver: don't forward DNS-SD on all platforms

Browse Source 
We added the initial handling only for macOS and iOS.
With 1.16.0 now released, suppress forwarding DNS-SD
on all platforms to test it through the 1.17.x cycle.

Updates #2442

Signed-off-by: Denton Gentry <dgentry@tailscale.com>
This commit is contained in:
Denton Gentry 2021-10-08 05:57:16 -07:00 committed by Denton Gentry
parent e5dddb2b99
commit d883747d8b
1 changed files with 6 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
net/dns/resolver/forwarder.go
View File

@ -519,18 +519,12 @@ func (f *forwarder) forward(query packet) error {
} }
// Drop DNS service discovery spam, primarily for battery life // Drop DNS service discovery spam, primarily for battery life
// on mobile. This is scoped to only Apple platforms, as // on mobile. Things like Spotify on iOS generate this traffic,
// that's where we see it. Things like Spotify on iOS // when browsing for LAN devices. But even when filtering this
// generate this traffic, when browsing for LAN devices. But // out, playing on Sonos still works.
// even when filtering this out, playing on Sonos still works. if hasRDNSBonjourPrefix(domain) {
// f.logf("[v1] dropping %q", domain)
// TODO(bradfitz): maybe after 1.16 is out, do it more broadly? return nil
switch runtime.GOOS {
case "ios", "darwin":
if hasRDNSBonjourPrefix(domain) {
f.logf("[v1] dropping %q", domain)
return nil
}
} }
clampEDNSSize(query.bs, maxResponseBytes) clampEDNSSize(query.bs, maxResponseBytes)