From d9c21936c3e21825e3cd2422868a8d6293241300 Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Tue, 23 Nov 2021 14:18:03 -0800 Subject: [PATCH] control/controlclient: stop logging about goal.url invariant This isn't the ideal solution, but it's good enough for now. Signed-off-by: Josh Bleecher Snyder --- control/controlclient/auto.go | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/control/controlclient/auto.go b/control/controlclient/auto.go index c9d676597..9ca307bfb 100644 --- a/control/controlclient/auto.go +++ b/control/controlclient/auto.go @@ -339,11 +339,9 @@ func (c *Auto) authRoutine() { continue } if url != "" { - if goal.url != "" { - err = fmt.Errorf("[unexpected] server required a new URL?") - report(err, "WaitLoginURL") - } - + // goal.url ought to be empty here. + // However, not all control servers get this right, + // and logging about it here just generates noise. c.mu.Lock() c.loginGoal = &LoginGoal{ wantLoggedIn: true,