From da8e8eb86f569169df996eae5174848cd252385d Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Tue, 1 Apr 2025 04:01:00 -0700 Subject: [PATCH] types/logger, logpolicy: disable rate limiting, don't upload on Plan 9 To ease local debugging and have fewer moving pieces while bringing up Plan 9 support. Updates #5794 Change-Id: I2dc98e73bbb0d4d4730dc47203efc0550a0ac0a0 Signed-off-by: Brad Fitzpatrick --- logpolicy/logpolicy.go | 2 +- types/logger/logger.go | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/logpolicy/logpolicy.go b/logpolicy/logpolicy.go index 1419fff65..11c6bf14c 100644 --- a/logpolicy/logpolicy.go +++ b/logpolicy/logpolicy.go @@ -627,7 +627,7 @@ func (opts Options) New() *Policy { conf.IncludeProcSequence = true } - if envknob.NoLogsNoSupport() || testenv.InTest() { + if envknob.NoLogsNoSupport() || testenv.InTest() || runtime.GOOS == "plan9" { opts.Logf("You have disabled logging. Tailscale will not be able to provide support.") conf.HTTPC = &http.Client{Transport: noopPretendSuccessTransport{}} } else { diff --git a/types/logger/logger.go b/types/logger/logger.go index 11596b357..66b989480 100644 --- a/types/logger/logger.go +++ b/types/logger/logger.go @@ -14,6 +14,7 @@ import ( "fmt" "io" "log" + "runtime" "strings" "sync" "time" @@ -162,6 +163,10 @@ func RateLimitedFnWithClock(logf Logf, f time.Duration, burst int, maxCache int, if envknob.String("TS_DEBUG_LOG_RATE") == "all" { return logf } + if runtime.GOOS == "plan9" { + // To ease bring-up. + return logf + } var ( mu sync.Mutex msgLim = make(map[string]*limitData) // keyed by logf format