From e7caad61fb62108e491a7e757528e2c83fac2b29 Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Mon, 8 Feb 2021 13:34:27 -0800 Subject: [PATCH] wgengine: remove IpcGetOperation filter This was in place because retrieved allowed_ips was very expensive. Upstream changed the data structure to make them cheaper to compute. This commit is an experiment to find out whether they're now cheap enough. Signed-off-by: Josh Bleecher Snyder --- wgengine/userspace.go | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/wgengine/userspace.go b/wgengine/userspace.go index 282b79c7d..5793232b4 100644 --- a/wgengine/userspace.go +++ b/wgengine/userspace.go @@ -1075,12 +1075,7 @@ func (e *userspaceEngine) getStatus() (*Status, error) { defer pw.Close() // TODO(apenwarr): get rid of silly uapi stuff for in-process comms // FIXME: get notified of status changes instead of polling. - filter := device.IPCGetFilter{ - // The allowed_ips are somewhat expensive to compute and they're - // unused below; request that they not be sent instead. - FilterAllowedIPs: true, - } - err := e.wgdev.IpcGetOperationFiltered(pw, filter) + err := e.wgdev.IpcGetOperation(pw) if err != nil { err = fmt.Errorf("IpcGetOperation: %w", err) }