From ecf5d69c7ca678a626a1964fadffdd21272f6472 Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Wed, 8 Jul 2020 15:26:56 -0700 Subject: [PATCH] net/netcheck: add missing comment asked for in earlier code review --- net/netcheck/netcheck.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/net/netcheck/netcheck.go b/net/netcheck/netcheck.go index a5f8a8f18..c2990bd98 100644 --- a/net/netcheck/netcheck.go +++ b/net/netcheck/netcheck.go @@ -673,7 +673,11 @@ func (rs *reportState) probePortMapServices() { } if n == 60 && res[0] == 0x02 { // right length and version 2 rs.setOptBool(&rs.report.PCP, true) - // Delete the mapping. + + // And now delete the mapping. + // (PCP is the only protocol of the three that requires + // we cause a side effect to detect whether it's present, + // so we need to redo that side effect now.) uc.WriteTo(pcpPacket(myIP, tempPort, true), port5351) } }