TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-12-01 09:32:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

cmd/cloner,*: optimize nillable slice cloner

Browse Source 
A wild @josharian appears with a good suggestion for a refactor, thanks
Josh!

Updates #9410
Signed-off-by: James Tucker <james@tailscale.com>
This commit is contained in:
James Tucker
2023-09-29 17:29:17 -07:00
committed by James Tucker
parent e91e96dfa5
commit ee90cd02fd
5 changed files with 34 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
wgengine/filter/filter_clone.go
View File

@@ -23,11 +23,9 @@ func (src *Match) Clone() *Match {
dst.IPProto = append(src.IPProto[:0:0], src.IPProto...)
dst.Srcs = append(src.Srcs[:0:0], src.Srcs...)
dst.Dsts = append(src.Dsts[:0:0], src.Dsts...)
if src.Caps != nil {
dst.Caps = make([]CapMatch, len(src.Caps))
for i := range dst.Caps {
dst.Caps[i] = *src.Caps[i].Clone()
}
dst.Caps = append([]CapMatch(nil), make([]CapMatch, len(src.Caps))...)
for i := range dst.Caps {
dst.Caps[i] = *src.Caps[i].Clone()
}
return dst
}

8
wgengine/wgcfg/wgcfg_clone.go
View File

@@ -24,11 +24,9 @@ func (src *Config) Clone() *Config {
*dst = *src
dst.Addresses = append(src.Addresses[:0:0], src.Addresses...)
dst.DNS = append(src.DNS[:0:0], src.DNS...)
if src.Peers != nil {
dst.Peers = make([]Peer, len(src.Peers))
for i := range dst.Peers {
dst.Peers[i] = *src.Peers[i].Clone()
}
dst.Peers = append([]Peer(nil), make([]Peer, len(src.Peers))...)
for i := range dst.Peers {
dst.Peers[i] = *src.Peers[i].Clone()
}
return dst
}