From f09a4bde65f3ebce576346be531154b14362a828 Mon Sep 17 00:00:00 2001 From: Dmytro Shynkevych Date: Fri, 17 Jul 2020 03:27:43 -0400 Subject: [PATCH] router/dns: minor fixes Signed-off-by: Dmytro Shynkevych --- wgengine/router/dns/nm.go | 3 +-- wgengine/router/dns/resolved.go | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/wgengine/router/dns/nm.go b/wgengine/router/dns/nm.go index eb2245aa9..9e2c197bb 100644 --- a/wgengine/router/dns/nm.go +++ b/wgengine/router/dns/nm.go @@ -69,7 +69,6 @@ func (m *nmManager) Up(config Config) error { if err != nil { return fmt.Errorf("connecting to system bus: %w", err) } - defer conn.Close() // This is how we get at the DNS settings: // org.freedesktop.NetworkManager @@ -207,7 +206,7 @@ func (m *nmManager) Up(config Config) error { } err = connection.CallWithContext( - ctx, "org.freedesktop.NetworkManager.Settings.Connection.UpdateUnsaved", 0, settings, + ctx, "org.freedesktop.NetworkManager.Settings.Connection.Update", 0, settings, ).Store() if err != nil { return fmt.Errorf("setting Settings: %w", err) diff --git a/wgengine/router/dns/resolved.go b/wgengine/router/dns/resolved.go index 41be1dfb5..98b530d92 100644 --- a/wgengine/router/dns/resolved.go +++ b/wgengine/router/dns/resolved.go @@ -89,7 +89,6 @@ func (m *resolvedManager) Up(config Config) error { if err != nil { return fmt.Errorf("connecting to system bus: %w", err) } - defer conn.Close() resolved := conn.Object( "org.freedesktop.resolve1",