TheArchive/tailscale
1
0
Fork 0
mirror of https://github.com/tailscale/tailscale.git synced 2025-04-18 12:32:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleanup and comment

Browse Source 
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
This commit is contained in:
Kristoffer Dalby 2024-09-23 11:24:05 +02:00
parent c1e0cbed49
commit f9e26d6281
No known key found for this signature in database
1 changed files with 18 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
tsnet/tsnet_test.go
View File

@ -943,6 +943,17 @@ func promMetricLabelsStr(labels []*dto.LabelPair) string {
} }
// TestUserMetrics tests the user-facing metrics exposed by tailscaled. // TestUserMetrics tests the user-facing metrics exposed by tailscaled.
// Metrics for the following is validated in this test:
// - Advertised routes
// - Approved routes
// - Primary routes
// - Inbound bytes over direct connection (ipv4)
// - Outbound bytes over direct connection (ipv4)
// - Tailscale health messages
//
// Inbound and outbound packets are not tested as it varies based on
// the platform the test is run on based on different network
// configuration windows.
func TestUserMetrics(t *testing.T) { func TestUserMetrics(t *testing.T) {
flakytest.Mark(t, "https://github.com/tailscale/tailscale/issues/13420") flakytest.Mark(t, "https://github.com/tailscale/tailscale/issues/13420")
tstest.ResourceCheck(t) tstest.ResourceCheck(t)
@ -1011,6 +1022,7 @@ func TestUserMetrics(t *testing.T) {
return status1.Self.PrimaryRoutes != nil && status1.Self.PrimaryRoutes.Len() == 3 return status1.Self.PrimaryRoutes != nil && status1.Self.PrimaryRoutes.Len() == 3
}) })
// 10 megabytes
bytesToSend := 10 * 1024 * 1024 bytesToSend := 10 * 1024 * 1024
// This asserts generates some traffic, it is factored out // This asserts generates some traffic, it is factored out
@ -1078,23 +1090,11 @@ func TestUserMetrics(t *testing.T) {
t.Errorf("metrics1, tailscaled_inbound_bytes_total,path=direct_ipv4: expected higher than %d, got: %f", bytesToSend, inboundBytes1) t.Errorf("metrics1, tailscaled_inbound_bytes_total,path=direct_ipv4: expected higher than %d, got: %f", bytesToSend, inboundBytes1)
} }
// But ensure that it is not too much higher than the 10 megabytes sent, given 20% wiggle room. // But ensure that it is not too much higher than the 10 megabytes sent, given 10% wiggle room.
if inboundBytes1 > float64(bytesToSend)*1.2 { if inboundBytes1 > float64(bytesToSend)*1.1 {
t.Errorf("metrics1, tailscaled_inbound_bytes_total,path=direct_ipv4: expected lower than %f, got: %f", float64(bytesToSend)*1.2, inboundBytes1) t.Errorf("metrics1, tailscaled_inbound_bytes_total,path=direct_ipv4: expected lower than %f, got: %f", float64(bytesToSend)*1.1, inboundBytes1)
} }
// // Verify that the packet count recorded is higher than the
// // 10 000 1KB packages we sent.
// inboundPackets1 := parsedMetrics1["tailscaled_inbound_packets_total,path=direct_ipv4,"]
// if inboundPackets1 < float64(packets) {
// t.Errorf("metrics1, tailscaled_inbound_bytes_total,path=direct_ipv4: expected higher than %d, got: %f", packets, inboundPackets1)
// }
// // But ensure that it is not too much higher than the 10 megabytes sent, given 20% wiggle room.
// if inboundPackets1 > float64(packets)*1.2 {
// t.Errorf("metrics1, tailscaled_inbound_bytes_total,path=direct_ipv4: expected lower than %f, got: %f", float64(packets)*1.1, inboundPackets1)
// }
metrics2, err := lc2.UserMetrics(ctx) metrics2, err := lc2.UserMetrics(ctx)
if err != nil { if err != nil {
t.Fatal(err) t.Fatal(err)
@ -1139,22 +1139,10 @@ func TestUserMetrics(t *testing.T) {
t.Errorf("metrics2, tailscaled_outbound_bytes_total,path=direct_ipv4: expected higher than %d, got: %f", bytesToSend, outboundBytes2) t.Errorf("metrics2, tailscaled_outbound_bytes_total,path=direct_ipv4: expected higher than %d, got: %f", bytesToSend, outboundBytes2)
} }
// But ensure that it is not too much higher than the 10 megabytes sent, given 20% wiggle room. // But ensure that it is not too much higher than the 10 megabytes sent, given 10% wiggle room.
if outboundBytes2 > float64(bytesToSend)*1.2 { if outboundBytes2 > float64(bytesToSend)*1.1 {
t.Errorf("metrics2, tailscaled_outbound_bytes_total,path=direct_ipv4: expected lower than %f, got: %f", float64(bytesToSend)*1.2, outboundBytes2) t.Errorf("metrics2, tailscaled_outbound_bytes_total,path=direct_ipv4: expected lower than %f, got: %f", float64(bytesToSend)*1.1, outboundBytes2)
} }
// // Verify that the packet count recorded is higher than the
// // 10 000 1KB packages we sent.
// outboundPackets2 := parsedMetrics2["tailscaled_outbound_packets_total,path=direct_ipv4,"]
// if outboundPackets2 < float64(packets) {
// t.Errorf("metrics2, tailscaled_outbound_bytes_total,path=direct_ipv4: expected higher than %d, got: %f", packets, outboundPackets2)
// }
// // But ensure that it is not too much higher than the 10 megabytes sent, given 20% wiggle room.
// if outboundPackets2 > float64(packets)*1.2 {
// t.Errorf("metrics2, tailscaled_outbound_bytes_total,path=direct_ipv4: expected lower than %f, got: %f", float64(packets)*1.1, outboundPackets2)
// }
} }
func waitForCondition(t *testing.T, msg string, waitTime time.Duration, f func() bool) { func waitForCondition(t *testing.T, msg string, waitTime time.Duration, f func() bool) {