From fccba5a2f1a5e5dbde9e2fa57e33651b8fd047eb Mon Sep 17 00:00:00 2001
From: Mike O'Driscoll <mikeo@tailscale.com>
Date: Tue, 13 May 2025 09:19:18 -0400
Subject: [PATCH] prober: fix test logic (#15952)

Catch failing tests that have no expected error string.

Updates #15912

Signed-off-by: Mike O'Driscoll <mikeo@tailscale.com>
---
 prober/tls_test.go | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/prober/tls_test.go b/prober/tls_test.go
index cf5b60cb8..9ba17f79d 100644
--- a/prober/tls_test.go
+++ b/prober/tls_test.go
@@ -252,7 +252,7 @@ func TestCRL(t *testing.T) {
 			"NoCRL",
 			leafCertParsed,
 			nil,
-			"",
+			"no CRL server presented in leaf cert for",
 		},
 		{
 			"NotBeforeCRLStaplingDate",
@@ -276,7 +276,7 @@ func TestCRL(t *testing.T) {
 				return
 			}
 
-			if err == nil || !strings.Contains(err.Error(), tt.wantErr) {
+			if err == nil || tt.wantErr == "" || !strings.Contains(err.Error(), tt.wantErr) {
 				t.Errorf("unexpected error %q; want %q", err, tt.wantErr)
 			}
 		})