Brad Fitzpatrick
6fbc9b3a98
control/controlclient: cache Windows version
...
To atone for 1d7f9d5b4a
, the revert of 4224b3f731
.
At least it's fast again, even if it's shelling out to cmd.exe (once now).
Updates #1478
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
2021-03-15 21:40:32 -07:00
Brad Fitzpatrick
1d7f9d5b4a
Revert "control/controlclient: use API to get Windows version number"
...
This reverts commit 4224b3f731
.
From https://github.com/tailscale/tailscale/pull/1494#discussion_r594852889 ...
> Actually, I want all four numbers back. I spent the evening
> debugging an issue for a user running an old version of Windows
> and then going to to
> https://en.wikipedia.org/wiki/Windows_10_version_history_(version_1809)
> and reading all the revision notes in the footnotes of that wikipedia
> page.
>
> I'm going to revert this for now for Tailscale 1.6. We can land it
> again later when we figure out how to get the fourth numbers.
Updates #1478
2021-03-15 21:28:48 -07:00
Aleksandar Pesic
4224b3f731
control/controlclient: use API to get Windows version number
...
Fixes #1478
Signed-off-by: Aleksandar Pesic <peske.nis@gmail.com>
2021-03-15 10:06:42 -07:00
Brad Fitzpatrick
662c19551a
control/controlclient: deal with localized 'Version' string getting Windows version
2020-09-13 10:06:20 -07:00
Brad Fitzpatrick
b77d752623
control/controlclient: populate OSVersion on Windows
2020-07-27 21:46:07 -07:00