5 Commits

Author	SHA1	Message	Date
Josh Bleecher Snyder	7bd89359c9	cmd/cloner: generate a package-level Clone function ... This Clone function knows how to clone any types for which it has generated Clone methods. This allows callers to efficiently clone an inbound interface{} that might contain one of these types. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	2020-09-04 16:25:18 -07:00
Josh Bleecher Snyder	99d223130c	cmd/cloner: fix found type detection ... This was causing any type to be reported as found, as long as there were any type decls at all. Oops. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	2020-09-04 13:43:17 -07:00
Josh Bleecher Snyder	2352690bde	cmd/cloner: ensure cloner gets re-run when structs change ... If you change a struct and don't re-run cloner, your Cloner method might be inaccurate, leading to bad things. To prevent this, write out the struct as it is at the moment that cloner is caller, and attempt a conversion from that type. If the struct gets changed in any way, this conversion will fail. This will yield false positives: If you change a non-pointer field, you will be forced to re-run cloner, even though the actual generated code won't change. I think this is an acceptable cost: It is a minor annoyance, which will prevent real bugs. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>	2020-09-04 13:11:21 -07:00
Brad Fitzpatrick	ec4feaf31c	cmd/cloner, tailcfg: fix nil vs len 0 issues, add tests, use for Hostinfo ... Also use go:generate and https://golang.org/s/generatedcode header style. Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>	2020-07-27 14:11:41 -07:00
David Crawshaw	961b9c8abf	cmd/cloner: tool to generate Clone methods ... Signed-off-by: David Crawshaw <crawshaw@tailscale.com>	2020-07-27 11:08:09 +10:00