tailscale/ipn
Andrea Gottardo 949b15d858
net/captivedetection: call SetHealthy once connectivity restored (#12974)
Fixes tailscale/tailscale#12973
Updates tailscale/tailscale#1634

There was a logic issue in the captive detection code we shipped in https://github.com/tailscale/tailscale/pull/12707.

Assume a captive portal has been detected, and the user notified. Upon switching to another Wi-Fi that does *not* have a captive portal, we were issuing a signal to interrupt any pending captive detection attempt. However, we were not also setting the `captive-portal-detected` warnable to healthy. The result was that any "captive portal detected" alert would not be cleared from the UI.

Also fixes a broken log statement value.

Signed-off-by: Andrea Gottardo <andrea@gottardo.me>
2024-07-30 13:39:25 -07:00
..
conffile cmd/tailscaled, ipn/conffile: support ec2 user-data config file 2024-05-30 09:49:18 -07:00
ipnauth go.mod, all: move away from inet.af domain seized by Taliban 2024-02-13 19:21:09 -08:00
ipnlocal net/captivedetection: call SetHealthy once connectivity restored (#12974) 2024-07-30 13:39:25 -07:00
ipnserver all: add test for package comments, fix, add comments as needed 2024-07-10 09:57:00 -07:00
ipnstate cmd/tailscale/cli: print node signature in tailscale lock status 2024-05-31 10:11:25 +01:00
localapi cmd/tailscale: add --min-validity flag to the cert command (#12822) 2024-07-19 09:35:22 -07:00
policy ipn,tailconfig: clean up unreleased and removed app connector service 2023-11-09 22:36:52 -08:00
store all: add test for package comments, fix, add comments as needed 2024-07-10 09:57:00 -07:00
backend.go health: begin work to use structured health warnings instead of strings, pipe changes into ipn.Notify (#12406) 2024-06-14 11:53:56 -07:00
conf.go ipn,wgengine/magicsock: allow setting static node endpoints via tailscaled configfile (#12882) 2024-07-23 16:50:55 +01:00
doc.go all: update copyright and license headers 2023-01-27 15:36:29 -08:00
ipn_clone.go cmd/cloner, cmd/viewer, util/codegen: add support for generic types and interfaces 2024-07-11 16:38:53 -05:00
ipn_test.go all: do not depend on the testing package 2024-05-24 05:23:36 -07:00
ipn_view.go ipn,wgengine: remove vestigial Prefs.AllowSingleHosts 2024-05-17 20:50:19 -07:00
prefs_test.go ipn: allow FQDN in exit node selection 2024-07-15 11:22:30 -04:00
prefs.go ipn: allow FQDN in exit node selection 2024-07-15 11:22:30 -04:00
serve_test.go cmd/serve: don't convert localhost to 127.0.0.1 2024-06-26 20:57:19 -07:00
serve.go cmd/serve: don't convert localhost to 127.0.0.1 2024-06-26 20:57:19 -07:00
store_test.go ipn: avoid useless no-op WriteState calls 2023-08-07 08:44:24 -07:00
store.go ipn: add comment about thread-safety to StateStore 2024-03-06 12:42:18 -06:00