mirror of
https://github.com/tailscale/tailscale.git
synced 2025-12-31 00:08:06 +00:00
This updates the syspolicy package to support multiple policy sources in the three policy scopes: user, profile, and device, and provides a merged resultant policy. A policy source is a syspolicy/source.Store that has a name and provides access to policy settings for a given scope. It can be registered with syspolicy/rsop.RegisterStore. Policy sources and policy stores can be either platform-specific or platform-agnostic. On Windows, we have the Registry-based, platform-specific policy store implemented as syspolicy/source.PlatformPolicyStore. This store provides access to the Group Policy and MDM policy settings stored in the Registry. On other platforms, we currently provide a wrapper that converts a syspolicy.Handler into a syspolicy/source.Store. However, we should update them in follow-up PRs. An example of a platform-agnostic policy store would be a policy deployed from the control, a local policy config file, or even environment variables. We maintain the current, most recent version of the resultant policy for each scope in an rsop.Policy. This is done by reading and merging the policy settings from the registered stores the first time the resultant policy is requested, then re-reading and re-merging them if a store implements the source.Changeable interface and reports a policy change. Policy change notifications are debounced to avoid re-reading policy settings multiple times if there are several changes within a short period. The rsop.Policy can notify clients if the resultant policy has changed. However, we do not currently expose this via the syspolicy package and plan to do so differently along with a struct-based policy hierarchy in the next PR. To facilitate this, all policy settings should be registered with the setting.Register function. The syspolicy package does this automatically for all policy settings defined in policy_keys.go. The new functionality is available through the existing syspolicy.Read* set of functions. However, we plan to expose it via a struct-based policy hierarchy, along with policy change notifications that other subsystems can use, in the next PR. We also plan to send the resultant policy back from tailscaled to the clients via the LocalAPI. This is primarily a foundational PR to facilitate future changes, but the immediate observable changes on Windows include: - The service will use the current policy setting values instead of those read at OS boot time. - The GUI has access to policy settings configured on a per-user basis. On Android: - We now report policy setting usage via clientmetrics. Updates #12687 Signed-off-by: Nick Khyl <nickk@tailscale.com>
109 lines
3.4 KiB
Go
109 lines
3.4 KiB
Go
// Copyright (c) Tailscale Inc & AUTHORS
|
|
// SPDX-License-Identifier: BSD-3-Clause
|
|
|
|
package syspolicy
|
|
|
|
import (
|
|
"tailscale.com/util/syspolicy/internal"
|
|
"tailscale.com/util/syspolicy/rsop"
|
|
"tailscale.com/util/syspolicy/setting"
|
|
"tailscale.com/util/syspolicy/source"
|
|
)
|
|
|
|
// Handler reads system policies from OS-specific storage.
|
|
//
|
|
// Deprecated: implementing a [Store] should be preferred.
|
|
type Handler interface {
|
|
// ReadString reads the policy setting's string value for the given key.
|
|
// It should return ErrNoSuchKey if the key does not have a value set.
|
|
ReadString(key string) (string, error)
|
|
// ReadUInt64 reads the policy setting's uint64 value for the given key.
|
|
// It should return ErrNoSuchKey if the key does not have a value set.
|
|
ReadUInt64(key string) (uint64, error)
|
|
// ReadBool reads the policy setting's boolean value for the given key.
|
|
// It should return ErrNoSuchKey if the key does not have a value set.
|
|
ReadBoolean(key string) (bool, error)
|
|
// ReadStringArray reads the policy setting's string array value for the given key.
|
|
// It should return ErrNoSuchKey if the key does not have a value set.
|
|
ReadStringArray(key string) ([]string, error)
|
|
}
|
|
|
|
// RegisterHandler wraps and registers the specified handler as the device's
|
|
// policy [Store] for the program's lifetime.
|
|
//
|
|
// Deprecated: using [RegisterStore] should be preferred.
|
|
func RegisterHandler(h Handler) {
|
|
rsop.RegisterStore("DeviceHandler", setting.DeviceScope, WrapHandler(h))
|
|
}
|
|
|
|
// TB is a subset of testing.TB that we use to set up test helpers.
|
|
// It's defined here to avoid pulling in the testing package.
|
|
type TB = internal.TB
|
|
|
|
// SetHandlerForTest wraps and sets the specified handler as the device's policy
|
|
// [Store] for the duration of tb.
|
|
//
|
|
// Deprecated: using [resultant.RegisterStoreForTest] should be preferred.
|
|
func SetHandlerForTest(tb TB, h Handler) {
|
|
if err := setWellKnownSettingsForTest(tb); err != nil {
|
|
tb.Fatalf("setWellKnownSettingsForTest failed: %v", err)
|
|
}
|
|
rsop.RegisterStoreForTest(tb, "DeviceHandler-TestOnly", setting.CurrentScope(), WrapHandler(h))
|
|
}
|
|
|
|
var _ source.Store = (*handlerStore)(nil)
|
|
|
|
// handlerStore is a [source.Store] that calls the underlying [Handler].
|
|
// TODO(nickkhyl): remove it when the corp and android repos are updated.
|
|
type handlerStore struct {
|
|
h Handler
|
|
}
|
|
|
|
// WrapHandler returns a [source.Store] that wraps the specified [Handler].
|
|
func WrapHandler(h Handler) source.Store {
|
|
return handlerStore{h}
|
|
}
|
|
|
|
func (s handlerStore) Lock() error {
|
|
if lockable, ok := s.h.(source.Lockable); ok {
|
|
return lockable.Lock()
|
|
}
|
|
return nil
|
|
}
|
|
|
|
func (s handlerStore) Unlock() {
|
|
if lockable, ok := s.h.(source.Lockable); ok {
|
|
lockable.Unlock()
|
|
}
|
|
}
|
|
|
|
func (s handlerStore) RegisterChangeCallback(callback func()) (unregister func(), err error) {
|
|
if lockable, ok := s.h.(source.Changeable); ok {
|
|
return lockable.RegisterChangeCallback(callback)
|
|
}
|
|
return func() {}, nil
|
|
}
|
|
|
|
func (s handlerStore) ReadString(key setting.Key) (string, error) {
|
|
return s.h.ReadString(string(key))
|
|
}
|
|
|
|
func (s handlerStore) ReadUInt64(key setting.Key) (uint64, error) {
|
|
return s.h.ReadUInt64(string(key))
|
|
}
|
|
|
|
func (s handlerStore) ReadBoolean(key setting.Key) (bool, error) {
|
|
return s.h.ReadBoolean(string(key))
|
|
}
|
|
|
|
func (s handlerStore) ReadStringArray(key setting.Key) ([]string, error) {
|
|
return s.h.ReadStringArray(string(key))
|
|
}
|
|
|
|
func (s handlerStore) Done() <-chan struct{} {
|
|
if expirable, ok := s.h.(source.Expirable); ok {
|
|
return expirable.Done()
|
|
}
|
|
return nil
|
|
}
|