mirror of
https://github.com/tailscale/tailscale.git
synced 2024-11-29 13:05:46 +00:00
3f576fc4ca
Updates #cleanup Signed-off-by: Andrew Dunham <andrew@du.nham.ca> Change-Id: Ice78fc907bad24c1de749a1595e212ef2db4b8bb
105 lines
2.7 KiB
YAML
105 lines
2.7 KiB
YAML
linters:
|
|
# Don't enable any linters by default; just the ones that we explicitly
|
|
# enable in the list below.
|
|
disable-all: true
|
|
enable:
|
|
- bidichk
|
|
- gofmt
|
|
- goimports
|
|
- govet
|
|
- misspell
|
|
- revive
|
|
|
|
# Configuration for how we run golangci-lint
|
|
run:
|
|
timeout: 5m
|
|
|
|
issues:
|
|
# Excluding configuration per-path, per-linter, per-text and per-source
|
|
exclude-rules:
|
|
# These are forks of an upstream package and thus are exempt from stylistic
|
|
# changes that would make pulling in upstream changes harder.
|
|
- path: tempfork/.*\.go
|
|
text: "File is not `gofmt`-ed with `-s` `-r 'interface{} -> any'`"
|
|
- path: util/singleflight/.*\.go
|
|
text: "File is not `gofmt`-ed with `-s` `-r 'interface{} -> any'`"
|
|
|
|
# Per-linter settings are contained in this top-level key
|
|
linters-settings:
|
|
# Enable all rules by default; we don't use invisible unicode runes.
|
|
bidichk:
|
|
|
|
gofmt:
|
|
rewrite-rules:
|
|
- pattern: 'interface{}'
|
|
replacement: 'any'
|
|
|
|
goimports:
|
|
|
|
govet:
|
|
# Matches what we use in corp as of 2023-12-07
|
|
enable:
|
|
- asmdecl
|
|
- assign
|
|
- atomic
|
|
- bools
|
|
- buildtag
|
|
- cgocall
|
|
- copylocks
|
|
- deepequalerrors
|
|
- errorsas
|
|
- framepointer
|
|
- httpresponse
|
|
- ifaceassert
|
|
- loopclosure
|
|
- lostcancel
|
|
- nilfunc
|
|
- nilness
|
|
- printf
|
|
- reflectvaluecompare
|
|
- shift
|
|
- sigchanyzer
|
|
- sortslice
|
|
- stdmethods
|
|
- stringintconv
|
|
- structtag
|
|
- testinggoroutine
|
|
- tests
|
|
- unmarshal
|
|
- unreachable
|
|
- unsafeptr
|
|
- unusedresult
|
|
settings:
|
|
printf:
|
|
# List of print function names to check (in addition to default)
|
|
funcs:
|
|
- github.com/tailscale/tailscale/types/logger.Discard
|
|
# NOTE(andrew-d): this doesn't currently work because the printf
|
|
# analyzer doesn't support type declarations
|
|
#- github.com/tailscale/tailscale/types/logger.Logf
|
|
|
|
misspell:
|
|
|
|
revive:
|
|
enable-all-rules: false
|
|
ignore-generated-header: true
|
|
rules:
|
|
- name: atomic
|
|
- name: context-keys-type
|
|
- name: defer
|
|
arguments: [[
|
|
# Calling 'recover' at the time a defer is registered (i.e. "defer recover()") has no effect.
|
|
"immediate-recover",
|
|
# Calling 'recover' outside of a deferred function has no effect
|
|
"recover",
|
|
# Returning values from a deferred function has no effect
|
|
"return",
|
|
]]
|
|
- name: duplicated-imports
|
|
- name: errorf
|
|
- name: string-of-int
|
|
- name: time-equal
|
|
- name: unconditional-recursion
|
|
- name: useless-break
|
|
- name: waitgroup-by-value
|