tailscale/control/controlclient
Brad Fitzpatrick 8fd471ce57 control/controlclient: disable https on for http://localhost:$port URLs
Previously we required the program to be running in a test or have
TS_CONTROL_IS_PLAINTEXT_HTTP before we disabled its https fallback
on "http" schema control URLs to localhost with ports.

But nobody accidentally does all three of "http", explicit port
number, localhost and doesn't mean it. And when they mean it, they're
testing a localhost dev control server (like I was) and don't want 443
getting involved.

As of the changes for #13597, this became more annoying in that we
were trying to use a port which wasn't even available.

Updates #13597

Change-Id: Icd00bca56043d2da58ab31de7aa05a3b269c490f
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
2024-11-14 12:12:16 -08:00
..
auto.go control/controlclient: delete unused Client.Login Oauth2Token field 2024-05-17 19:51:18 -07:00
client.go control/controlclient: delete unused Client.Login Oauth2Token field 2024-05-17 19:51:18 -07:00
controlclient_test.go all: use Go 1.22 range-over-int 2024-04-16 15:32:38 -07:00
direct_test.go tka: test SigCredential signatures and netmap filtering 2024-06-27 19:28:57 +01:00
direct.go control/controlclient: include HTTP status string in error message too 2024-10-03 08:37:16 -07:00
map_test.go all: use Go 1.22 range-over-int 2024-04-16 15:32:38 -07:00
map.go all: use new Go 1.23 slices.Sorted more 2024-09-04 14:52:21 -07:00
noise_test.go control/controlhttp/controlhttpserver: split out Accept to its own package 2024-11-07 22:29:41 -08:00
noise.go control/controlclient: disable https on for http://localhost:$port URLs 2024-11-14 12:12:16 -08:00
sign_supported_test.go all: update copyright and license headers 2023-01-27 15:36:29 -08:00
sign_supported.go control/controlclient,posture,util/syspolicy: use predefined syspolicy keys instead of string literals 2024-09-04 15:25:19 -05:00
sign_unsupported.go control/controlclient: support certstore without cgo 2023-10-20 15:17:32 -04:00
sign.go all: update copyright and license headers 2023-01-27 15:36:29 -08:00
status.go all: implement AppendText alongside MarshalText (#9207) 2023-09-01 18:15:19 -07:00