tailscale/net/dns
James Tucker af5a845a87 net/dns/resolver: fix dns-sd NXDOMAIN responses from quad-100
mdnsResponder at least as of macOS Sequoia does not find NXDOMAIN
responses to these dns-sd PTR queries acceptable unless they include the
question section in the response. This was found debugging #13511, once
we turned on additional diagnostic reporting from mdnsResponder we
witnessed:

```
Received unacceptable 12-byte response from 100.100.100.100 over UDP via utun6/27 -- id: 0x7F41 (32577), flags: 0x8183 (R/Query, RD, RA, NXDomain), counts: 0/0/0/0,
```

If the response includes a question section, the resposnes are
acceptable, e.g.:

```
Received acceptable 59-byte response from 8.8.8.8 over UDP via en0/17 -- id: 0x2E55 (11861), flags: 0x8183 (R/Query, RD, RA, NXDomain), counts: 1/0/0/0,
```

This may be contributing to an issue under diagnosis in #13511 wherein
some combination of conditions results in mdnsResponder no longer
answering DNS queries correctly to applications on the system for
extended periods of time (multiple minutes), while dig against quad-100
provides correct responses for those same domains. If additional debug
logging is enabled in mdnsResponder we see it reporting:

```
Penalizing server 100.100.100.100 for 60 seconds
```

It is also possible that the reason that macOS & iOS never "stopped
spamming" these queries is that they have never been replied to with
acceptable responses. It is not clear if this special case handling of
dns-sd PTR queries was ever beneficial, and given this evidence may have
always been harmful. If we subsequently observe that the queries settle
down now that they have acceptable responses, we should remove these
special cases - making upstream queries very occasionally isn't a lot of
battery, so we should be better off having to maintain less special
cases and avoid bugs of this class.

Updates #2442
Updates #3025
Updates #3363
Updates #3594
Updates #13511

Signed-off-by: James Tucker <james@tailscale.com>
2024-09-18 18:43:03 -07:00
..
publicdns net/dns/publicdns: remove additional information in DOH URL passed to IPv6 address generation for controlD. 2024-07-10 16:14:05 -04:00
recursive all: use Go 1.22 range-over-int 2024-04-16 15:32:38 -07:00
resolvconffile clientupdate, net/dns: fix some "tailsacle" typos 2024-04-03 21:08:25 -07:00
resolver net/dns/resolver: fix dns-sd NXDOMAIN responses from quad-100 2024-09-18 18:43:03 -07:00
config.go all: add test for package comments, fix, add comments as needed 2024-07-10 09:57:00 -07:00
debian_resolvconf.go all: update copyright and license headers 2023-01-27 15:36:29 -08:00
direct_linux.go net/dns: updated gonotify dependency to v2 that supports closable context 2024-08-22 12:36:26 -07:00
direct_notlinux.go all: update copyright and license headers 2023-01-27 15:36:29 -08:00
direct_test.go clientupdate, net/dns: fix some "tailsacle" typos 2024-04-03 21:08:25 -07:00
direct_unix_test.go net/dns: ensure /etc/resolv.conf is world-readable even with a umask 2024-06-26 00:02:05 -04:00
direct.go net/dns: ensure /etc/resolv.conf is world-readable even with a umask 2024-06-26 00:02:05 -04:00
flush_default.go all: update copyright and license headers 2023-01-27 15:36:29 -08:00
flush_windows.go cmd/tailscaled, net/dns, wgengine/router: start Windows child processes with DETACHED_PROCESS when I/O is being piped 2024-06-11 11:35:26 -06:00
ini_test.go all: update copyright and license headers 2023-01-27 15:36:29 -08:00
ini.go all: update copyright and license headers 2023-01-27 15:36:29 -08:00
manager_darwin.go net/dns: support GetBaseConfig on Darwin OSS tailscaled (#13351) 2024-09-04 10:31:58 -07:00
manager_default.go various: create a catch-all NRPT rule when "Override local DNS" is enabled on Windows 2024-06-14 14:41:50 -05:00
manager_freebsd.go various: create a catch-all NRPT rule when "Override local DNS" is enabled on Windows 2024-06-14 14:41:50 -05:00
manager_linux_test.go net/dns: ensure /etc/resolv.conf is world-readable even with a umask 2024-06-26 00:02:05 -04:00
manager_linux.go various: create a catch-all NRPT rule when "Override local DNS" is enabled on Windows 2024-06-14 14:41:50 -05:00
manager_openbsd.go various: create a catch-all NRPT rule when "Override local DNS" is enabled on Windows 2024-06-14 14:41:50 -05:00
manager_tcp_test.go net/dns, health: raise health warning for failing forwarded DNS queries (#12888) 2024-07-29 13:48:46 -04:00
manager_test.go net/dns: ensure multiple hosts with the same IP address are combined into a single HostEntry 2024-06-21 13:16:49 -06:00
manager_windows_test.go util/winutil/gp, net/dns: add package for Group Policy API 2024-07-08 20:37:03 -05:00
manager_windows.go net/dns: disable DNS registration for Tailscale interface on Windows 2024-09-07 19:00:38 +01:00
manager.go cli: implement tailscale dns status (#13353) 2024-09-04 19:43:55 +00:00
nm.go all: cleanup unused code, part 2 (#10670) 2023-12-21 17:40:03 -08:00
noop.go all: update copyright and license headers 2023-01-27 15:36:29 -08:00
nrpt_windows.go util/winutil/gp, net/dns: add package for Group Policy API 2024-07-08 20:37:03 -05:00
openresolv.go net/dns: log more info when openresolv commands fail 2024-02-13 20:48:54 -05:00
osconfig_test.go net/dns: fix IsZero and Equal methods on OSConfig 2024-09-05 00:05:36 -04:00
osconfig.go net/dns: fix IsZero and Equal methods on OSConfig 2024-09-05 00:05:36 -04:00
resolvconf-workaround.sh all: update copyright and license headers 2023-01-27 15:36:29 -08:00
resolvconf.go net/dns: properly detect newer debian resolvconf 2023-10-11 08:38:25 -07:00
resolvconfpath_default.go net/dns: overwrite /tmp/resolv.conf on gokrazy 2023-07-23 09:53:32 -07:00
resolvconfpath_gokrazy.go net/dns: overwrite /tmp/resolv.conf on gokrazy 2023-07-23 09:53:32 -07:00
resolvd.go all: update copyright and license headers 2023-01-27 15:36:29 -08:00
resolved.go health, all: remove health.Global, finish plumbing health.Tracker 2024-04-26 12:03:11 -07:00
utf_test.go all: update copyright and license headers 2023-01-27 15:36:29 -08:00
utf.go all: update copyright and license headers 2023-01-27 15:36:29 -08:00
wsl_windows.go net/dns: ensure /etc/resolv.conf is world-readable even with a umask 2024-06-26 00:02:05 -04:00