tailscale/ipn
Brad Fitzpatrick cc575fe4d6 net/dns: schedule DoH upgrade explicitly, fix Resolver.Addr confusion
Two changes in one:

* make DoH upgrades an explicitly scheduled send earlier, when we come
  up with the resolvers-and-delay send plan. Previously we were
  getting e.g.  four Google DNS IPs and then spreading them out in
  time (for back when we only did UDP) but then later we added DoH
  upgrading at the UDP packet layer, which resulted in sometimes
  multiple DoH queries to the same provider running (each doing happy
  eyeballs dialing to 4x IPs themselves) for each of the 4 source IPs.
  Instead, take those 4 Google/Cloudflare IPs and schedule 5 things:
  first the DoH query (which can use all 4 IPs), and then each of the
  4 IPs as UDP later.

* clean up the dnstype.Resolver.Addr confusion; half the code was
  using it as an IP string (as documented) as half was using it as
  an IP:port (from some prior type we used), primarily for tests.
  Instead, document it was being primarily an IP string but also
  accepting an IP:port for tests, then add an accessor method on it
  to get the IPPort and use that consistently everywhere.

Change-Id: Ifdd72b9e45433a5b9c029194d50db2b9f9217b53
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
2022-04-19 12:00:22 -07:00
..
ipnlocal net/dns: schedule DoH upgrade explicitly, fix Resolver.Addr confusion 2022-04-19 12:00:22 -07:00
ipnserver all: use any instead of interface{} 2022-03-17 11:35:09 -07:00
ipnstate tailcfg, control/controlclient: TSMP & disco pings 2022-04-15 22:36:51 -07:00
localapi cmd/tailscale, etc: make "tailscale up --ssh" fail fast when unavailable 2022-04-18 09:45:46 -07:00
policy ipn/policy: treat DNS service as interesting so it's not filtered out 2021-12-03 12:55:54 -08:00
store ipn/store: [TestNewStore] do not use an empty file 2022-02-28 18:26:24 -08:00
backend.go ipn: use key.NodePublic instead of tailcfg.NodeKey 2021-11-01 20:32:10 -07:00
doc.go Move Linux client & common packages into a public repo. 2020-02-09 09:32:57 -08:00
fake_test.go ipn{,/ipnlocal}, cmd/tailscale/cli: don't check pref reverts on initial up 2021-04-18 08:12:18 -07:00
handle.go ipn: another controlplane synonym 2021-07-13 08:22:10 -07:00
message_test.go all: use any instead of interface{} 2022-03-17 11:35:09 -07:00
message.go ipn: don't log IPN messages that may contain an authkey. 2021-09-22 20:32:49 -07:00
prefs_clone.go wgengine/netstack: add an SSH server experiment 2022-01-24 19:14:13 -08:00
prefs_test.go cmd/tailscale/cli, ipn: move exit node IP parsing and validation from cli into prefs. 2022-03-10 10:51:05 -07:00
prefs.go all: use any instead of interface{} 2022-03-17 11:35:09 -07:00
store.go ipn/store: add common package for instantiating ipn.StateStores 2022-02-28 13:23:33 -08:00