mirror of
https://github.com/tailscale/tailscale.git
synced 2024-11-29 13:05:46 +00:00
2a2228f97b
We add setting.RawValue, a new type that facilitates unmarshalling JSON numbers and arrays as uint64 and []string (instead of float64 and []any) for policy setting values. We then use it to make setting.RawItem JSON-marshallable and update the tests. Updates #12687 Signed-off-by: Nick Khyl <nickk@tailscale.com>
163 lines
5.2 KiB
Go
163 lines
5.2 KiB
Go
// Copyright (c) Tailscale Inc & AUTHORS
|
|
// SPDX-License-Identifier: BSD-3-Clause
|
|
|
|
package setting
|
|
|
|
import (
|
|
"fmt"
|
|
"reflect"
|
|
|
|
jsonv2 "github.com/go-json-experiment/json"
|
|
"github.com/go-json-experiment/json/jsontext"
|
|
"tailscale.com/types/opt"
|
|
"tailscale.com/types/structs"
|
|
)
|
|
|
|
// RawItem contains a raw policy setting value as read from a policy store, or an
|
|
// error if the requested setting could not be read from the store. As a special
|
|
// case, it may also hold a value of the [Visibility], [PreferenceOption],
|
|
// or [time.Duration] types. While the policy store interface does not support
|
|
// these types natively, and the values of these types have to be unmarshalled
|
|
// or converted from strings, these setting types predate the typed policy
|
|
// hierarchies, and must be supported at this layer.
|
|
type RawItem struct {
|
|
_ structs.Incomparable
|
|
data rawItemJSON
|
|
}
|
|
|
|
// rawItemJSON holds JSON-marshallable data for [RawItem].
|
|
type rawItemJSON struct {
|
|
Value RawValue `json:",omitzero"`
|
|
Error *ErrorText `json:",omitzero"` // or nil
|
|
Origin *Origin `json:",omitzero"` // or nil
|
|
}
|
|
|
|
// RawItemOf returns a [RawItem] with the specified value.
|
|
func RawItemOf(value any) RawItem {
|
|
return RawItemWith(value, nil, nil)
|
|
}
|
|
|
|
// RawItemWith returns a [RawItem] with the specified value, error and origin.
|
|
func RawItemWith(value any, err *ErrorText, origin *Origin) RawItem {
|
|
return RawItem{data: rawItemJSON{Value: RawValue{opt.ValueOf(value)}, Error: err, Origin: origin}}
|
|
}
|
|
|
|
// Value returns the value of the policy setting, or nil if the policy setting
|
|
// is not configured, or an error occurred while reading it.
|
|
func (i RawItem) Value() any {
|
|
return i.data.Value.Get()
|
|
}
|
|
|
|
// Error returns the error that occurred when reading the policy setting,
|
|
// or nil if no error occurred.
|
|
func (i RawItem) Error() error {
|
|
if i.data.Error != nil {
|
|
return i.data.Error
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// Origin returns an optional [Origin] indicating where the policy setting is
|
|
// configured.
|
|
func (i RawItem) Origin() *Origin {
|
|
return i.data.Origin
|
|
}
|
|
|
|
// String implements [fmt.Stringer].
|
|
func (i RawItem) String() string {
|
|
var suffix string
|
|
if i.data.Origin != nil {
|
|
suffix = fmt.Sprintf(" - {%v}", i.data.Origin)
|
|
}
|
|
if i.data.Error != nil {
|
|
return fmt.Sprintf("Error{%q}%s", i.data.Error.Error(), suffix)
|
|
}
|
|
return fmt.Sprintf("%v%s", i.data.Value.Value, suffix)
|
|
}
|
|
|
|
// MarshalJSONV2 implements [jsonv2.MarshalerV2].
|
|
func (i RawItem) MarshalJSONV2(out *jsontext.Encoder, opts jsonv2.Options) error {
|
|
return jsonv2.MarshalEncode(out, &i.data, opts)
|
|
}
|
|
|
|
// UnmarshalJSONV2 implements [jsonv2.UnmarshalerV2].
|
|
func (i *RawItem) UnmarshalJSONV2(in *jsontext.Decoder, opts jsonv2.Options) error {
|
|
return jsonv2.UnmarshalDecode(in, &i.data, opts)
|
|
}
|
|
|
|
// MarshalJSON implements [json.Marshaler].
|
|
func (i RawItem) MarshalJSON() ([]byte, error) {
|
|
return jsonv2.Marshal(i) // uses MarshalJSONV2
|
|
}
|
|
|
|
// UnmarshalJSON implements [json.Unmarshaler].
|
|
func (i *RawItem) UnmarshalJSON(b []byte) error {
|
|
return jsonv2.Unmarshal(b, i) // uses UnmarshalJSONV2
|
|
}
|
|
|
|
// RawValue represents a raw policy setting value read from a policy store.
|
|
// It is JSON-marshallable and facilitates unmarshalling of JSON values
|
|
// into corresponding policy setting types, with special handling for JSON numbers
|
|
// (unmarshalled as float64) and JSON string arrays (unmarshalled as []string).
|
|
// See also [RawValue.UnmarshalJSONV2].
|
|
type RawValue struct {
|
|
opt.Value[any]
|
|
}
|
|
|
|
// RawValueType is a constraint that permits raw setting value types.
|
|
type RawValueType interface {
|
|
bool | uint64 | string | []string
|
|
}
|
|
|
|
// RawValueOf returns a new [RawValue] holding the specified value.
|
|
func RawValueOf[T RawValueType](v T) RawValue {
|
|
return RawValue{opt.ValueOf[any](v)}
|
|
}
|
|
|
|
// MarshalJSONV2 implements [jsonv2.MarshalerV2].
|
|
func (v RawValue) MarshalJSONV2(out *jsontext.Encoder, opts jsonv2.Options) error {
|
|
return jsonv2.MarshalEncode(out, v.Value, opts)
|
|
}
|
|
|
|
// UnmarshalJSONV2 implements [jsonv2.UnmarshalerV2] by attempting to unmarshal
|
|
// a JSON value as one of the supported policy setting value types (bool, string, uint64, or []string),
|
|
// based on the JSON value type. It fails if the JSON value is an object, if it's a JSON number that
|
|
// cannot be represented as a uint64, or if a JSON array contains anything other than strings.
|
|
func (v *RawValue) UnmarshalJSONV2(in *jsontext.Decoder, opts jsonv2.Options) error {
|
|
var valPtr any
|
|
switch k := in.PeekKind(); k {
|
|
case 't', 'f':
|
|
valPtr = new(bool)
|
|
case '"':
|
|
valPtr = new(string)
|
|
case '0':
|
|
valPtr = new(uint64) // unmarshal JSON numbers as uint64
|
|
case '[', 'n':
|
|
valPtr = new([]string) // unmarshal arrays as string slices
|
|
case '{':
|
|
return fmt.Errorf("unexpected token: %v", k)
|
|
default:
|
|
panic("unreachable")
|
|
}
|
|
if err := jsonv2.UnmarshalDecode(in, valPtr, opts); err != nil {
|
|
v.Value.Clear()
|
|
return err
|
|
}
|
|
value := reflect.ValueOf(valPtr).Elem().Interface()
|
|
v.Value = opt.ValueOf(value)
|
|
return nil
|
|
}
|
|
|
|
// MarshalJSON implements [json.Marshaler].
|
|
func (v RawValue) MarshalJSON() ([]byte, error) {
|
|
return jsonv2.Marshal(v) // uses MarshalJSONV2
|
|
}
|
|
|
|
// UnmarshalJSON implements [json.Unmarshaler].
|
|
func (v *RawValue) UnmarshalJSON(b []byte) error {
|
|
return jsonv2.Unmarshal(b, v) // uses UnmarshalJSONV2
|
|
}
|
|
|
|
// RawValues is a map of keyed setting values that can be read from a JSON.
|
|
type RawValues map[Key]RawValue
|