mirror of
https://github.com/tailscale/tailscale.git
synced 2024-11-29 04:55:31 +00:00
46ce80758d
In prep for reducing garbage, being able to reuse memory. So far this doesn't actually reuse much. This is just changing signatures around. But some improvement in any case: bradfitz@tsdev:~/src/tailscale.com$ ~/go/bin/benchstat before after name old time/op new time/op delta GetList-8 11.8ms ± 9% 9.9ms ± 3% -15.98% (p=0.000 n=10+10) name old alloc/op new alloc/op delta GetList-8 99.5kB ± 2% 91.9kB ± 0% -7.62% (p=0.000 n=9+9) name old allocs/op new allocs/op delta GetList-8 3.05k ± 1% 2.93k ± 0% -3.83% (p=0.000 n=8+9) More later, once parsers can reuse strings from previous parses. Updates #5958 Change-Id: I76cd5048246dd24d11c4e263d8bb8041747fb2b0 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
207 lines
4.8 KiB
Go
207 lines
4.8 KiB
Go
// Copyright (c) 2020 Tailscale Inc & AUTHORS All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package portlist
|
|
|
|
import (
|
|
"net"
|
|
"testing"
|
|
|
|
"tailscale.com/tstest"
|
|
)
|
|
|
|
func TestGetList(t *testing.T) {
|
|
tstest.ResourceCheck(t)
|
|
|
|
var p Poller
|
|
pl, err := p.getList()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
for i, p := range pl {
|
|
t.Logf("[%d] %+v", i, p)
|
|
}
|
|
t.Logf("As String: %v", pl.String())
|
|
}
|
|
|
|
func TestIgnoreLocallyBoundPorts(t *testing.T) {
|
|
tstest.ResourceCheck(t)
|
|
|
|
ln, err := net.Listen("tcp", "127.0.0.1:0")
|
|
if err != nil {
|
|
t.Skipf("failed to bind: %v", err)
|
|
}
|
|
defer ln.Close()
|
|
ta := ln.Addr().(*net.TCPAddr)
|
|
port := ta.Port
|
|
var p Poller
|
|
pl, err := p.getList()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
for _, p := range pl {
|
|
if p.Proto == "tcp" && int(p.Port) == port {
|
|
t.Fatal("didn't expect to find test's localhost ephemeral port")
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestLessThan(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
a, b Port
|
|
want bool
|
|
}{
|
|
{
|
|
"Port a < b",
|
|
Port{Proto: "tcp", Port: 100, Process: "proc1", inode: "inode1"},
|
|
Port{Proto: "tcp", Port: 101, Process: "proc1", inode: "inode1"},
|
|
true,
|
|
},
|
|
{
|
|
"Port a > b",
|
|
Port{Proto: "tcp", Port: 101, Process: "proc1", inode: "inode1"},
|
|
Port{Proto: "tcp", Port: 100, Process: "proc1", inode: "inode1"},
|
|
false,
|
|
},
|
|
{
|
|
"Proto a < b",
|
|
Port{Proto: "tcp", Port: 100, Process: "proc1", inode: "inode1"},
|
|
Port{Proto: "udp", Port: 100, Process: "proc1", inode: "inode1"},
|
|
true,
|
|
},
|
|
{
|
|
"Proto a < b",
|
|
Port{Proto: "udp", Port: 100, Process: "proc1", inode: "inode1"},
|
|
Port{Proto: "tcp", Port: 100, Process: "proc1", inode: "inode1"},
|
|
false,
|
|
},
|
|
{
|
|
"inode a < b",
|
|
Port{Proto: "tcp", Port: 100, Process: "proc1", inode: "inode1"},
|
|
Port{Proto: "tcp", Port: 100, Process: "proc1", inode: "inode2"},
|
|
true,
|
|
},
|
|
{
|
|
"inode a > b",
|
|
Port{Proto: "tcp", Port: 100, Process: "proc2", inode: "inode2"},
|
|
Port{Proto: "tcp", Port: 100, Process: "proc1", inode: "inode1"},
|
|
false,
|
|
},
|
|
{
|
|
"Process a < b",
|
|
Port{Proto: "tcp", Port: 100, Process: "proc1", inode: "inode1"},
|
|
Port{Proto: "tcp", Port: 100, Process: "proc2", inode: "inode1"},
|
|
true,
|
|
},
|
|
{
|
|
"Process a > b",
|
|
Port{Proto: "tcp", Port: 100, Process: "proc2", inode: "inode1"},
|
|
Port{Proto: "tcp", Port: 100, Process: "proc1", inode: "inode1"},
|
|
false,
|
|
},
|
|
{
|
|
"Port evaluated first",
|
|
Port{Proto: "udp", Port: 100, Process: "proc2", inode: "inode2"},
|
|
Port{Proto: "tcp", Port: 101, Process: "proc1", inode: "inode1"},
|
|
true,
|
|
},
|
|
{
|
|
"Proto evaluated second",
|
|
Port{Proto: "tcp", Port: 100, Process: "proc2", inode: "inode2"},
|
|
Port{Proto: "udp", Port: 100, Process: "proc1", inode: "inode1"},
|
|
true,
|
|
},
|
|
{
|
|
"inode evaluated third",
|
|
Port{Proto: "tcp", Port: 100, Process: "proc2", inode: "inode1"},
|
|
Port{Proto: "tcp", Port: 100, Process: "proc1", inode: "inode2"},
|
|
true,
|
|
},
|
|
{
|
|
"Process evaluated fourth",
|
|
Port{Proto: "tcp", Port: 100, Process: "proc1", inode: "inode1"},
|
|
Port{Proto: "tcp", Port: 100, Process: "proc2", inode: "inode1"},
|
|
true,
|
|
},
|
|
{
|
|
"equal",
|
|
Port{Proto: "tcp", Port: 100, Process: "proc1", inode: "inode1"},
|
|
Port{Proto: "tcp", Port: 100, Process: "proc1", inode: "inode1"},
|
|
false,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
got := tt.a.lessThan(&tt.b)
|
|
if got != tt.want {
|
|
t.Errorf("%s: Equal = %v; want %v", tt.name, got, tt.want)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestSameInodes(t *testing.T) {
|
|
port1 := Port{Proto: "tcp", Port: 100, Process: "proc", inode: "inode1"}
|
|
port2 := Port{Proto: "tcp", Port: 100, Process: "proc", inode: "inode1"}
|
|
portProto := Port{Proto: "udp", Port: 100, Process: "proc", inode: "inode1"}
|
|
portPort := Port{Proto: "tcp", Port: 101, Process: "proc", inode: "inode1"}
|
|
portInode := Port{Proto: "tcp", Port: 100, Process: "proc", inode: "inode2"}
|
|
portProcess := Port{Proto: "tcp", Port: 100, Process: "other", inode: "inode1"}
|
|
|
|
tests := []struct {
|
|
name string
|
|
a, b List
|
|
want bool
|
|
}{
|
|
{
|
|
"identical",
|
|
List{port1, port1},
|
|
List{port2, port2},
|
|
true,
|
|
},
|
|
{
|
|
"proto differs",
|
|
List{port1, port1},
|
|
List{port2, portProto},
|
|
false,
|
|
},
|
|
{
|
|
"port differs",
|
|
List{port1, port1},
|
|
List{port2, portPort},
|
|
false,
|
|
},
|
|
{
|
|
"inode differs",
|
|
List{port1, port1},
|
|
List{port2, portInode},
|
|
false,
|
|
},
|
|
{
|
|
// SameInodes does not check the Process field
|
|
"Process differs",
|
|
List{port1, port1},
|
|
List{port2, portProcess},
|
|
true,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
got := tt.a.sameInodes(tt.b)
|
|
if got != tt.want {
|
|
t.Errorf("%s: Equal = %v; want %v", tt.name, got, tt.want)
|
|
}
|
|
}
|
|
}
|
|
|
|
func BenchmarkGetList(b *testing.B) {
|
|
b.ReportAllocs()
|
|
var p Poller
|
|
for i := 0; i < b.N; i++ {
|
|
_, err := p.getList()
|
|
if err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
}
|
|
}
|