mirror of
https://github.com/tailscale/tailscale.git
synced 2024-11-29 13:05:46 +00:00
08acb502e5
If a test calls log.Printf, 'go test' horrifyingly rearranges the output to no longer be in chronological order, which makes debugging virtually impossible. Let's stop that from happening by making log.Printf panic if called from any module, no matter how deep, during tests. This required us to change the default error handler in at least one http.Server, as well as plumbing a bunch of logf functions around, especially in magicsock and wgengine, but also in logtail and backoff. To add insult to injury, 'go test' also rearranges the output when a parent test has multiple sub-tests (all the sub-test's t.Logf is always printed after all the parent tests t.Logf), so we need to screw around with a special Logf that can point at the "current" t (current_t.Logf) in some places. Probably our entire way of using subtests is wrong, since 'go test' would probably like to run them all in parallel if you called t.Parallel(), but it definitely can't because the're all manipulating the shared state created by the parent test. They should probably all be separate toplevel tests instead, with common setup/teardown logic. But that's a job for another time. Signed-off-by: Avery Pennarun <apenwarr@tailscale.com>
66 lines
1.6 KiB
Go
66 lines
1.6 KiB
Go
// Copyright (c) 2020 Tailscale Inc & AUTHORS All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package backoff
|
|
|
|
import (
|
|
"context"
|
|
"math/rand"
|
|
"time"
|
|
|
|
"tailscale.com/types/logger"
|
|
)
|
|
|
|
const MAX_BACKOFF_MSEC = 30000
|
|
|
|
type Backoff struct {
|
|
n int
|
|
// Name is the name of this backoff timer, for logging purposes.
|
|
name string
|
|
// logf is the function used for log messages when backing off.
|
|
logf logger.Logf
|
|
// NewTimer is the function that acts like time.NewTimer().
|
|
// You can override this in unit tests.
|
|
NewTimer func(d time.Duration) *time.Timer
|
|
// LogLongerThan sets the minimum time of a single backoff interval
|
|
// before we mention it in the log.
|
|
LogLongerThan time.Duration
|
|
}
|
|
|
|
func NewBackoff(name string, logf logger.Logf) Backoff {
|
|
return Backoff{
|
|
name: name,
|
|
logf: logf,
|
|
NewTimer: time.NewTimer,
|
|
}
|
|
}
|
|
|
|
func (b *Backoff) BackOff(ctx context.Context, err error) {
|
|
if ctx.Err() == nil && err != nil {
|
|
b.n++
|
|
// n^2 backoff timer is a little smoother than the
|
|
// common choice of 2^n.
|
|
msec := b.n * b.n * 10
|
|
if msec > MAX_BACKOFF_MSEC {
|
|
msec = MAX_BACKOFF_MSEC
|
|
}
|
|
// Randomize the delay between 0.5-1.5 x msec, in order
|
|
// to prevent accidental "thundering herd" problems.
|
|
msec = rand.Intn(msec) + msec/2
|
|
dur := time.Duration(msec) * time.Millisecond
|
|
if dur >= b.LogLongerThan {
|
|
b.logf("%s: backoff: %d msec\n", b.name, msec)
|
|
}
|
|
t := b.NewTimer(dur)
|
|
select {
|
|
case <-ctx.Done():
|
|
t.Stop()
|
|
case <-t.C:
|
|
}
|
|
} else {
|
|
// not a regular error
|
|
b.n = 0
|
|
}
|
|
}
|