mirror of
https://github.com/tailscale/tailscale.git
synced 2024-11-26 19:45:35 +00:00
7330aa593e
On some platforms (notably macOS and iOS) we look up the default interface to bind outgoing connections to. This is both duplicated work and results in logspam when the default interface is not available (i.e. when a phone has no connectivity, we log an error and thus cause more things that we will try to upload and fail). Fixed by passing around a netmon.Monitor to more places, so that we can use its cached interface state. Fixes #7850 Updates #7621 Signed-off-by: Mihai Parparita <mihai@tailscale.com>
85 lines
1.7 KiB
Go
85 lines
1.7 KiB
Go
// Copyright (c) Tailscale Inc & AUTHORS
|
|
// SPDX-License-Identifier: BSD-3-Clause
|
|
|
|
package netns
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"tailscale.com/net/interfaces"
|
|
)
|
|
|
|
func TestGetInterfaceIndex(t *testing.T) {
|
|
oldVal := bindToInterfaceByRoute.Load()
|
|
t.Cleanup(func() { bindToInterfaceByRoute.Store(oldVal) })
|
|
bindToInterfaceByRoute.Store(true)
|
|
|
|
tests := []struct {
|
|
name string
|
|
addr string
|
|
err string
|
|
}{
|
|
{
|
|
name: "IP_and_port",
|
|
addr: "8.8.8.8:53",
|
|
},
|
|
{
|
|
name: "bare_ip",
|
|
addr: "8.8.8.8",
|
|
},
|
|
{
|
|
name: "invalid",
|
|
addr: "!!!!!",
|
|
},
|
|
}
|
|
for _, tc := range tests {
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
idx, err := getInterfaceIndex(t.Logf, nil, tc.addr)
|
|
if err != nil {
|
|
if tc.err == "" {
|
|
t.Fatalf("got unexpected error: %v", err)
|
|
}
|
|
if errstr := err.Error(); errstr != tc.err {
|
|
t.Errorf("expected error %q, got %q", errstr, tc.err)
|
|
}
|
|
} else {
|
|
t.Logf("getInterfaceIndex(%q) = %d", tc.addr, idx)
|
|
if tc.err != "" {
|
|
t.Fatalf("wanted error %q", tc.err)
|
|
}
|
|
if idx < 0 {
|
|
t.Fatalf("got invalid index %d", idx)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
|
|
t.Run("NoTailscale", func(t *testing.T) {
|
|
_, tsif, err := interfaces.Tailscale()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if tsif == nil {
|
|
t.Skip("no tailscale interface on this machine")
|
|
}
|
|
|
|
defaultIdx, err := interfaces.DefaultRouteInterfaceIndex()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
idx, err := getInterfaceIndex(t.Logf, nil, "100.100.100.100:53")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
t.Logf("tailscaleIdx=%d defaultIdx=%d idx=%d", tsif.Index, defaultIdx, idx)
|
|
|
|
if idx == tsif.Index {
|
|
t.Fatalf("got idx=%d; wanted not Tailscale interface", idx)
|
|
} else if idx != defaultIdx {
|
|
t.Fatalf("got idx=%d, want %d", idx, defaultIdx)
|
|
}
|
|
})
|
|
}
|