tailscale/log/sockstatlog/logger_test.go
Mihai Parparita 7330aa593e all: avoid repeated default interface lookups
On some platforms (notably macOS and iOS) we look up the default
interface to bind outgoing connections to. This is both duplicated
work and results in logspam when the default interface is not available
(i.e. when a phone has no connectivity, we log an error and thus cause
more things that we will try to upload and fail).

Fixed by passing around a netmon.Monitor to more places, so that we can
use its cached interface state.

Fixes #7850
Updates #7621

Signed-off-by: Mihai Parparita <mihai@tailscale.com>
2023-04-20 15:46:01 -07:00

117 lines
2.4 KiB
Go

// Copyright (c) Tailscale Inc & AUTHORS
// SPDX-License-Identifier: BSD-3-Clause
package sockstatlog
import (
"testing"
"github.com/google/go-cmp/cmp"
"tailscale.com/net/sockstats"
"tailscale.com/tstest"
"tailscale.com/types/logger"
"tailscale.com/types/logid"
)
func TestResourceCleanup(t *testing.T) {
if !sockstats.IsAvailable {
t.Skip("sockstats not available")
}
tstest.ResourceCheck(t)
td := t.TempDir()
id, err := logid.NewPrivateID()
if err != nil {
t.Fatal(err)
}
lg, err := NewLogger(td, logger.Discard, id.Public(), nil)
if err != nil {
t.Fatal(err)
}
lg.Write([]byte("hello"))
lg.Shutdown()
}
func TestDelta(t *testing.T) {
tests := []struct {
name string
a, b *sockstats.SockStats
wantStats map[sockstats.Label]deltaStat
}{
{
name: "nil a stat",
a: nil,
b: &sockstats.SockStats{},
wantStats: nil,
},
{
name: "nil b stat",
a: &sockstats.SockStats{},
b: nil,
wantStats: nil,
},
{
name: "no change",
a: &sockstats.SockStats{
Stats: map[sockstats.Label]sockstats.SockStat{
sockstats.LabelDERPHTTPClient: {
TxBytes: 10,
},
},
},
b: &sockstats.SockStats{
Stats: map[sockstats.Label]sockstats.SockStat{
sockstats.LabelDERPHTTPClient: {
TxBytes: 10,
},
},
},
wantStats: nil,
},
{
name: "tx after empty stat",
a: &sockstats.SockStats{},
b: &sockstats.SockStats{
Stats: map[sockstats.Label]sockstats.SockStat{
sockstats.LabelDERPHTTPClient: {
TxBytes: 10,
},
},
},
wantStats: map[sockstats.Label]deltaStat{
sockstats.LabelDERPHTTPClient: {10, 0},
},
},
{
name: "rx after non-empty stat",
a: &sockstats.SockStats{
Stats: map[sockstats.Label]sockstats.SockStat{
sockstats.LabelDERPHTTPClient: {
TxBytes: 10,
RxBytes: 10,
},
},
},
b: &sockstats.SockStats{
Stats: map[sockstats.Label]sockstats.SockStat{
sockstats.LabelDERPHTTPClient: {
TxBytes: 10,
RxBytes: 30,
},
},
},
wantStats: map[sockstats.Label]deltaStat{
sockstats.LabelDERPHTTPClient: {0, 20},
},
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
gotStats := delta(tt.a, tt.b)
if !cmp.Equal(gotStats, tt.wantStats) {
t.Errorf("gotStats = %v, want %v", gotStats, tt.wantStats)
}
})
}
}