Josh Bleecher Snyder 93284209bc logtail/filch: preallocate a scanner buffer ... Scanning log lines is a frequent source of allocations. Pre-allocate a re-usable buffer. This still doesn't help when there are giant log lines. Those will still be problematic from an iOS memory perspective. For more on that, see https://github.com/tailscale/corp/issues/2423. (For those who cannot follow that link, it is a discussion of particular problematic types of log lines for particular categories of customers. The "categories of customers" part is the reason that it is a private issue.) There is also a latent bug here. If we ever encounter a log line longer than bufio.MaxScanTokenSize, then bufio.Scan will return an error, and we'll truncate the file and discard the rest of the log. That's not good, but bufio.MaxScanTokenSize is really big, so it probably doesn't matter much in practice now. Unfortunately, it does prevent us from easily capping the potential memory usage here, on pain of losing log entries. Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>		2021-08-17 12:32:10 -07:00
..
filch_test.go	logtail/filch: preallocate a scanner buffer	2021-08-17 12:32:10 -07:00
filch_unix.go	all: gofmt with Go 1.17	2021-08-05 15:54:00 -07:00
filch_windows.go	Move Linux client & common packages into a public repo.	2020-02-09 09:32:57 -08:00
filch.go	logtail/filch: preallocate a scanner buffer	2021-08-17 12:32:10 -07:00