tailscale/net
Josh Bleecher Snyder ad5e04249b wgengine/monitor: ignore adding/removing uninteresting IPs
One of the most common "unexpected" log lines is:

"network state changed, but stringification didn't"

One way that this can occur is if an interesting interface
(non-Tailscale, has interesting IP address)
gains or loses an uninteresting IP address (link local or loopback).

The fact that the interface is interesting is enough for EqualFiltered
to inspect it. The fact that an IP address changed is enough for
EqualFiltered to declare that the interfaces are not equal.

But the State.String method reasonably declines to print any
uninteresting IP addresses. As a result, the network state appears
to have changed, but the stringification did not.

The String method is correct; nothing interesting happened.

This change fixes this by adding an IP address filter to EqualFiltered
in addition to the interface filter. This lets the network monitor
ignore the addition/removal of uninteresting IP addresses.

Signed-off-by: Josh Bleecher Snyder <josh@tailscale.com>
2021-11-22 16:33:15 -08:00
..
dns net/dns: make constants for the various DBus strings. 2021-11-19 11:09:32 -08:00
dnscache net/{dnscache,interfaces}: use netaddr.IP.IsPrivate, delete copied code 2021-07-26 20:30:28 -07:00
dnsfallback net/netns: thread logf into control functions 2021-11-18 15:09:51 -08:00
flowtrack all: use testingutil.MinAllocsPerRun 2021-10-28 12:48:37 -07:00
interfaces wgengine/monitor: ignore adding/removing uninteresting IPs 2021-11-22 16:33:15 -08:00
netcheck net/netns: thread logf into control functions 2021-11-18 15:09:51 -08:00
netknob all: disable TCP keep-alives on iOS/Android 2021-09-28 12:03:18 -07:00
netns net/netns: thread logf into control functions 2021-11-18 15:09:51 -08:00
netstat all: gofmt with Go 1.17 2021-08-05 15:54:00 -07:00
nettest net/nettest: make nettest.NewConn pass x/net/nettest.TestConn. 2021-04-06 15:34:29 -07:00
packet all: use testingutil.MinAllocsPerRun 2021-10-28 12:48:37 -07:00
portmapper net/portmapper: mark fewer PMP probe failures as unexpected 2021-11-22 11:13:15 -08:00
socks5 net/socks5/tssocks: add a SOCKS5 dialer type, method-ifying code 2021-06-28 13:12:42 -07:00
speedtest all: fix spelling mistakes 2021-10-12 21:23:14 -07:00
stun all: gofmt with Go 1.17 2021-08-05 15:54:00 -07:00
tlsdial net/tlsdial: add forgotten test file for go mod tidy 2021-10-01 10:30:01 -07:00
tsaddr ipn/ipnlocal: for IPv6-only nodes, publish IPv6 MagicDNS records of peers 2021-10-04 08:54:23 -07:00
tshttpproxy net/tshttpproxy: use correct size for Windows BOOL argument 2021-11-22 12:24:24 -08:00
tstun net/tstun, wgengine: add packet-level and drop metrics 2021-11-17 16:18:52 -08:00