mirror of
https://github.com/tailscale/tailscale.git
synced 2025-07-10 23:58:44 +00:00

NewMultiLabelMap does not return an error so it's easy for someone to pass an incorrect/unsupported metric type and serve invalid metrics to Prometheus. This would read as `metrics.Counter` and `metrics.Gauge` when used, which seems readable enough; but if you think bare strings are better, an alternative to this approach might be to verify string value in `NewMultiLabelMap` and panic? Updates tailscale/corp#22075 Signed-off-by: Anton Tolchanov <anton@tailscale.com>