mirror of
https://github.com/tailscale/tailscale.git
synced 2024-11-25 19:15:34 +00:00
d32700c7b2
There are 5 types that we care about that implement AppendTo: key.DiscoPublic key.NodePublic netip.Prefix netipx.IPRange netip.Addr The key types are thin wrappers around [32]byte and are memory hashable. The netip.Prefix and netipx.IPRange types are thin wrappers over netip.Addr and are hashable by default if netip.Addr is hashable. The netip.Addr type is the only one with a complex structure where the default behavior of deephash does not hash it correctly due to the presence of the intern.Value type. Drop support for AppendTo and instead add specialized hashing for netip.Addr that would be semantically equivalent to == on the netip.Addr values. The AppendTo support was already broken prior to this change. It was fully removed (intentionally or not) in #4870. It was partially restored in #4858 for the fast path, but still broken in the slow path. Just drop support for it altogether. This does mean we lack any ability for types to self-hash themselves. In the future we can add support for types that implement: interface { DeepHash() Sum } Test and fuzz cases were added for the relevant types that used to rely on the AppendTo method. FuzzAddr has been executed on 1 billion samples without issues. Signed-off-by: Joe Tsai joetsai@digital-static.net |
||
|---|---|---|
| .. | ||
| cibuild | ||
| clientmetric | ||
| cloudenv | ||
| cmpver | ||
| codegen | ||
| deephash | ||
| dnsname | ||
| endian | ||
| groupmember | ||
| hashx | ||
| jsonutil | ||
| lineread | ||
| mak | ||
| multierr | ||
| must | ||
| osshare | ||
| pidowner | ||
| precompress | ||
| racebuild | ||
| singleflight | ||
| strs | ||
| systemd | ||
| uniq | ||
| winutil | ||