mirror of
https://github.com/tailscale/tailscale.git
synced 2024-11-29 13:05:46 +00:00
35bee36549
Turns out using win32 instead of shelling out to child processes is a
bit faster:
name old time/op new time/op delta
GetListIncremental-4 278ms ± 2% 0ms ± 7% -99.93% (p=0.000 n=8+10)
name old alloc/op new alloc/op delta
GetListIncremental-4 238kB ± 0% 9kB ± 0% -96.12% (p=0.000 n=10+8)
name old allocs/op new allocs/op delta
GetListIncremental-4 1.19k ± 0% 0.02k ± 0% -98.49% (p=0.000 n=10+10)
Fixes #3876 (sadly)
Change-Id: I1195ac5de21a8a8b3cdace5871d263e81aa27e91
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
35 lines
857 B
Go
35 lines
857 B
Go
// Copyright (c) 2020 Tailscale Inc & AUTHORS All rights reserved.
|
|
// Use of this source code is governed by a BSD-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
//go:build (windows || freebsd || openbsd || darwin) && !ios && !js
|
|
// +build windows freebsd openbsd darwin
|
|
// +build !ios
|
|
// +build !js
|
|
|
|
package portlist
|
|
|
|
import (
|
|
"fmt"
|
|
"os/exec"
|
|
"strings"
|
|
)
|
|
|
|
func appendListeningPortsNetstat(base []Port, arg string) ([]Port, error) {
|
|
exe, err := exec.LookPath("netstat")
|
|
if err != nil {
|
|
return nil, fmt.Errorf("netstat: lookup: %v", err)
|
|
}
|
|
output, err := exec.Command(exe, arg).Output()
|
|
if err != nil {
|
|
xe, ok := err.(*exec.ExitError)
|
|
stderr := ""
|
|
if ok {
|
|
stderr = strings.TrimSpace(string(xe.Stderr))
|
|
}
|
|
return nil, fmt.Errorf("netstat: %v (%q)", err, stderr)
|
|
}
|
|
|
|
return appendParsePortsNetstat(base, string(output)), nil
|
|
}
|